All of lore.kernel.org
 help / color / mirror / Atom feed
From: Samuel Ortiz <sameo@linux.intel.com>
To: Felipe Balbi <felipe.balbi@nokia.com>
Cc: "ext Gopinath, Thara" <thara@ti.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
	Tony Lindgren <tony@atomide.com>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 2/4] mfd: twl-core: switch over to defines in twl.h
Date: Sat, 21 Aug 2010 00:11:46 +0200	[thread overview]
Message-ID: <20100820221145.GM3650@sortiz-mobl> (raw)
In-Reply-To: <20100818071619.GE11947@nokia.com>

Hi Felipe,

On Wed, Aug 18, 2010 at 10:16:19AM +0300, Felipe Balbi wrote:
> Hi,
> 
> On Wed, Aug 18, 2010 at 09:10:22AM +0200, Balbi Felipe (Nokia-MS/Helsinki) wrote:
> >On Wed, Aug 18, 2010 at 09:03:44AM +0200, ext Gopinath, Thara wrote:
> >>>>No I am not talking about the key values. I was talking about the register offset
> >>>>for TWL4030_PM_MASTER_PROTECT_KEY. My question is, is it ok for it to be 0xd or 0xe.
> >>>>Earlier we were using 0xd and in the new implementation it has been changed to 0xe.
> >>
> >>Typo. Earlier we were using 0xe and in the new implementation it has
> >>been changed to 0xd.
> >
> >you're right, I'm not sure how I came up with that value since the TRM
> >shows 0x0e, maybe a copy&paste error. Will change patch 1.
> 
> ok, it's because there's no register 0x0a. And I missed that when
> defined the register space. Good catch, thanks. 
Should I expect a new patch then ?

Cheers,
Samuel.

-- 
Intel Open Source Technology Centre
http://oss.intel.com/

  parent reply	other threads:[~2010-08-20 22:11 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-18  6:19 [PATCH 0/4] twl PROTECT_KEY usage cleanup felipe.balbi
2010-08-18  6:19 ` [PATCH 1/4] i2c: twl: add register defines for pm master module felipe.balbi
2010-08-18  7:19   ` Felipe Balbi
2010-09-10 15:13     ` Samuel Ortiz
2010-08-18  6:19 ` [PATCH 2/4] mfd: twl-core: switch over to defines in twl.h felipe.balbi
2010-08-18  6:32   ` Gopinath, Thara
2010-08-18  6:59     ` Felipe Balbi
2010-08-18  7:02       ` Gopinath, Thara
2010-08-18  7:03       ` Gopinath, Thara
2010-08-18  7:10         ` Felipe Balbi
2010-08-18  7:16           ` Felipe Balbi
2010-08-18 14:20             ` Gopinath, Thara
2010-08-20 22:11             ` Samuel Ortiz [this message]
2010-08-21 14:07               ` Felipe Balbi
2010-08-18  6:19 ` [PATCH 3/4] mfd: twl4030-power: " felipe.balbi
2010-08-18  6:19 ` [PATCH 4/4] usb: otg: twl4030-usb: " felipe.balbi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100820221145.GM3650@sortiz-mobl \
    --to=sameo@linux.intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=felipe.balbi@nokia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=thara@ti.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.