From: Tyler Hicks <tyhicks@linux.vnet.ibm.com>
To: Jerome Marchand <jmarchan@redhat.com>
Cc: Dustin Kirkland <kirkland@canonical.com>,
ecryptfs-devel@lists.launchpad.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ecryptfs: properly mark init functions
Date: Fri, 20 Aug 2010 17:24:50 -0500 [thread overview]
Message-ID: <20100820222450.GA28193@boomer> (raw)
In-Reply-To: <4C6CEA20.5010802@redhat.com>
On Thu Aug 19, 2010 at 10:24:00AM +0200, Jerome Marchand <jmarchan@redhat.com> wrote:
> On 08/19/2010 02:28 AM, Tyler Hicks wrote:
> > On Tue Aug 17, 2010 at 05:24:05PM +0200, Jerome Marchand <jmarchan@redhat.com> wrote:
> >>
> >> Some ecryptfs init functions are not prefixed by __init and thus not
> >> freed after initialization. This patch saved about 1kB in ecryptfs
> >> module.
> >>
> >> Signed-off-by: Jerome Marchand <jmarchan@redhat.com>
> >> ---
> >
> > Thanks Jerome - We could also get away with marking
> > ecryptfs_init_kmem_caches() and do_sysfs_registration() with __init,
> > right?
> >
> > Tyler
> >
>
> I guess we could. But it doesn't really matter, these are static functions which
> are called from only one place, so they're inlined anyway. I don't know what the
> convention is in such case.
>
Good point - this has been applied to
git://git.kernel.org/pub/scm/linux/kernel/git/ecryptfs/ecryptfs-2.6.git#next
Thanks,
Tyler
prev parent reply other threads:[~2010-08-20 22:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-17 15:24 [PATCH] ecryptfs: properly mark init functions Jerome Marchand
2010-08-19 0:28 ` Tyler Hicks
2010-08-19 8:24 ` Jerome Marchand
2010-08-20 22:24 ` Tyler Hicks [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100820222450.GA28193@boomer \
--to=tyhicks@linux.vnet.ibm.com \
--cc=ecryptfs-devel@lists.launchpad.net \
--cc=jmarchan@redhat.com \
--cc=kirkland@canonical.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.