From: Sachin Sant <sachinp@in.ibm.com>
To: schwidefsky@de.ibm.com
Cc: Sachin Sant <sachinp@in.ibm.com>,
linux-s390@vger.kernel.org, dmitry.torokhov@gmail.com,
heiko.carstens@de.ibm.com, linux-kernel@vger.kernel.org,
linux-next@vger.kernel.org
Subject: [-next PATCH] Fix s390 keyboard driver build break
Date: Sat, 21 Aug 2010 12:51:26 +0530 [thread overview]
Message-ID: <20100821072126.8965.41003.sendpatchset@localhost.localdomain> (raw)
Next 20100820 fails to build on s390 with
drivers/s390/char/keyboard.c: In function 'kbd_keycode':
drivers/s390/char/keyboard.c:308: error: too many arguments to function 'handle_sysrq'
make[2]: *** [drivers/s390/char/keyboard.o] Error 1
The following commit changed handle_sysrq() function to accept single argument.
commit a821bafce37b26499e2bfbf2e6b96b0636efc014
Input: sysrq - drop tty argument form handle_sysrq()
Adapt the code accordingly to fix the build break.
Signed-off-by: Sachin Sant <sachinp@in.ibm.com>
---
diff -Naurp next20100820/drivers/s390/char/keyboard.c next20100820-new//drivers/s390/char/keyboard.c
--- next20100820/drivers/s390/char/keyboard.c 2010-08-16 06:11:37.000000000 +0530
+++ next20100820-new//drivers/s390/char/keyboard.c 2010-08-21 11:55:25.000000000 +0530
@@ -305,7 +305,7 @@ kbd_keycode(struct kbd_data *kbd, unsign
if (kbd->sysrq) {
if (kbd->sysrq == K(KT_LATIN, '-')) {
kbd->sysrq = 0;
- handle_sysrq(value, kbd->tty);
+ handle_sysrq(value);
return;
}
if (value == '-') {
next reply other threads:[~2010-08-21 7:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-21 7:21 Sachin Sant [this message]
2010-08-21 7:40 ` [-next PATCH] Fix s390 keyboard driver build break Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100821072126.8965.41003.sendpatchset@localhost.localdomain \
--to=sachinp@in.ibm.com \
--cc=dmitry.torokhov@gmail.com \
--cc=heiko.carstens@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=schwidefsky@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.