All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Bojan Smojver <bojan@rexursive.com>
Cc: linux-pm@lists.linux-foundation.org
Subject: Re: [PATCH 1/2] PM: Compress hibernation image with LZO
Date: Sun, 22 Aug 2010 21:29:14 +0200	[thread overview]
Message-ID: <201008222129.14250.rjw@sisk.pl> (raw)
In-Reply-To: <201008210136.27065.rjw@sisk.pl>

On Saturday, August 21, 2010, Rafael J. Wysocki wrote:
> On Friday, August 20, 2010, Bojan Smojver wrote:
> > On Thu, 2010-08-19 at 19:49 +1000, Bojan Smojver wrote:
> > > Not tested, but here it is
> > 
> > This one is tested with both nocompress option passed to the kernel and
> > without. Only one minor change compared to the previous patch -
> > calculation in enough_swap() also takes into account the compress v.
> > nocompress.
> 
> OK, it generally looks good.

One more remark, though.

Since LZO compression is hardcoded into your code, perhaps you can rename
save_image_cmp() to save_image_lzo() (and analogously in the other places)?

Thanks,
Rafael

  parent reply	other threads:[~2010-08-22 19:29 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-10  2:29 [PATCH 1/2] PM: Compress hibernation image with LZO Bojan Smojver
2010-08-17  0:52 ` Bojan Smojver
2010-08-17 10:55   ` Rafael J. Wysocki
2010-08-17 13:38     ` Bojan Smojver
2010-08-18 23:02 ` Rafael J. Wysocki
2010-08-18 23:41   ` Bojan Smojver
2010-08-19  9:49     ` Bojan Smojver
2010-08-19 11:11       ` Bojan Smojver
2010-08-20 23:32         ` Rafael J. Wysocki
2010-08-20 12:11       ` Bojan Smojver
2010-08-20 23:36         ` Rafael J. Wysocki
2010-08-21  4:40           ` Bojan Smojver
2010-08-22 19:23             ` Rafael J. Wysocki
2010-08-22 19:29           ` Rafael J. Wysocki [this message]
2010-08-22 22:33             ` Bojan Smojver
2010-08-22 23:47               ` Bojan Smojver
2010-08-23 21:43                 ` Rafael J. Wysocki
2010-08-23 23:20                   ` Bojan Smojver
2010-09-08 23:45                 ` Rafael J. Wysocki
2010-09-09  0:08                   ` Bojan Smojver
2010-08-21  6:15       ` Nigel Cunningham
2010-08-22 19:47         ` Rafael J. Wysocki
2010-08-22 21:52           ` Nigel Cunningham
2010-08-19 13:40     ` Rafael J. Wysocki
  -- strict thread matches above, loose matches on Subject: below --
2010-08-05  3:08 Bojan Smojver
2010-08-05  3:38 ` Bojan Smojver

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201008222129.14250.rjw@sisk.pl \
    --to=rjw@sisk.pl \
    --cc=bojan@rexursive.com \
    --cc=linux-pm@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.