From: Arnd Bergmann <arnd@arndb.de>
To: Namhyung Kim <namhyung@gmail.com>
Cc: Roland McGrath <roland@redhat.com>,
Oleg Nesterov <oleg@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] ptrace: add __force markup
Date: Sun, 22 Aug 2010 22:06:18 +0200 [thread overview]
Message-ID: <201008222206.18523.arnd@arndb.de> (raw)
In-Reply-To: <1282472536-7430-2-git-send-email-namhyung@gmail.com>
On Sunday 22 August 2010 12:22:15 Namhyung Kim wrote:
> index 4afd9b8..1abbb4d 100644
> --- a/kernel/ptrace.c
> +++ b/kernel/ptrace.c
> @@ -580,18 +580,19 @@ int ptrace_request(struct task_struct *child, long request,
> ret = ptrace_setoptions(child, data);
> break;
> case PTRACE_GETEVENTMSG:
> - ret = put_user(child->ptrace_message, (unsigned long __user *) data);
> + ret = put_user(child->ptrace_message,
> + (unsigned long __user __force *) data);
> break;
Maybe you should introduce a new temporary variable
void __user *p = (void __user __force*)data;
and get rid of all the other casts instead.
Arnd
next prev parent reply other threads:[~2010-08-22 20:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-22 10:22 [PATCH 2/3] ptrace: add __force markup Namhyung Kim
2010-08-22 20:06 ` Arnd Bergmann [this message]
2010-08-23 16:06 ` [PATCH 2/3 RESEND] ptrace: cleanup address space conversion on ptrace_request() Namhyung Kim
2010-08-23 16:21 ` Christoph Hellwig
2010-08-23 16:38 ` Namhyung Kim
2010-08-24 11:45 ` Arnd Bergmann
2010-08-25 7:48 ` Namhyung Kim
2010-08-25 11:42 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201008222206.18523.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=linux-kernel@vger.kernel.org \
--cc=namhyung@gmail.com \
--cc=oleg@redhat.com \
--cc=roland@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.