From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] xfs: do not discard page cache data on EAGAIN
Date: Mon, 23 Aug 2010 22:11:22 +1000 [thread overview]
Message-ID: <20100823121122.GH31488@dastard> (raw)
In-Reply-To: <20100823091015.GA2829@infradead.org>
On Mon, Aug 23, 2010 at 05:10:15AM -0400, Christoph Hellwig wrote:
> If xfs_map_blocks returns EAGAIN because of lock contention we must redirty
> the page and not disard the pagecache content and return an error from
> writepage. We used to do this correctly, but the logic got lost during
> the recent reshuffle of the writepage code.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> Reported-by: Mike Gao <ygao.linux@gmail.com>
> Tested-by: Mike Gao <ygao.linux@gmail.com>
Looks good.
Reviewed-by: Dave Chinner <dchinner@redhat.com>
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2010-08-23 12:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-23 9:10 [PATCH] xfs: do not discard page cache data on EAGAIN Christoph Hellwig
2010-08-23 12:11 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100823121122.GH31488@dastard \
--to=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.