From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=60953 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OnYRf-0003Tw-85 for qemu-devel@nongnu.org; Mon, 23 Aug 2010 10:56:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OnYRd-0006He-QZ for qemu-devel@nongnu.org; Mon, 23 Aug 2010 10:56:19 -0400 Received: from duck.dooz.org ([194.146.227.125]:47462) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OnYRd-0006HC-LV for qemu-devel@nongnu.org; Mon, 23 Aug 2010 10:56:17 -0400 Date: Mon, 23 Aug 2010 16:56:13 +0200 From: =?iso-8859-1?Q?Lo=EFc?= Minier Subject: Re: [Qemu-devel] [PATCH] fat_chksum(): fix access above array bounds Message-ID: <20100823145613.GD15935@bee.dooz.org> References: <1282430843-32308-1-git-send-email-loic.minier@linaro.org> <4C7288BC.9000804@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <4C7288BC.9000804@redhat.com> Content-Transfer-Encoding: quoted-printable List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: qemu-devel@nongnu.org On Mon, Aug 23, 2010, Kevin Wolf wrote: > How did you find this one? From a quick look it seems that the pattern > that name is intentionally overflowed to access extension is still ther= e > in some places. So if this caused some real bug, I think we'll have to > fix the other ones, too. Compiler found that one http://launchpadlibrarian.net/54142111/buildlog_ubuntu-maverick-armel.qe= mu-maemo_0.0~20100806%2Bd7a5eb1-0ubuntu1~linaro2_FAILEDTOBUILD.txt.gz but I didn't quote it because I'm at a loss as to why it detected it now and on armel only. I think I just got one accidental build on a modern gcc-4.4 tree because of the timing of my copy of the packages. I guess I should build them more regularly under a recent gcc. --=20 Lo=EFc Minier