All of lore.kernel.org
 help / color / mirror / Atom feed
From: akpm@linux-foundation.org
To: mm-commits@vger.kernel.org
Cc: linux@rainbow-software.org, rmk@arm.linux.org.uk
Subject: + cyber2000fb-avoid-palette-corruption-at-higher-clocks.patch added to -mm tree
Date: Mon, 23 Aug 2010 12:33:19 -0700	[thread overview]
Message-ID: <201008231933.o7NJXJ9R010514@imap1.linux-foundation.org> (raw)


The patch titled
     cyber2000fb: avoid palette corruption at higher clocks
has been added to the -mm tree.  Its filename is
     cyber2000fb-avoid-palette-corruption-at-higher-clocks.patch

Before you just go and hit "reply", please:
   a) Consider who else should be cc'ed
   b) Prefer to cc a suitable mailing list as well
   c) Ideally: find the original patch on the mailing list and do a
      reply-to-all to that, adding suitable additional cc's

*** Remember to use Documentation/SubmitChecklist when testing your code ***

See http://userweb.kernel.org/~akpm/stuff/added-to-mm.txt to find
out what to do about this

The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/

------------------------------------------------------
Subject: cyber2000fb: avoid palette corruption at higher clocks
From: Ondrej Zary <linux@rainbow-software.org>

When 1280x1024@75Hz mode is set, console palette is not set properly -
sometimes the background is white, sometimes yellow and text colors are
also messed up.  This does not happen at 1280x1024@60Hz and below.

It seems that the HW needs some time before setting the palette - maybe
the PLL needs more time to lock at higher speeds.  This patch fixes the
problem but without knowing what register to check for PLL lock(?), the
delay might be excessive.

Signed-off-by: Ondrej Zary <linux@rainbow-software.org>
Cc: Russell King <rmk@arm.linux.org.uk>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 drivers/video/cyber2000fb.c |    3 +++
 1 file changed, 3 insertions(+)

diff -puN drivers/video/cyber2000fb.c~cyber2000fb-avoid-palette-corruption-at-higher-clocks drivers/video/cyber2000fb.c
--- a/drivers/video/cyber2000fb.c~cyber2000fb-avoid-palette-corruption-at-higher-clocks
+++ a/drivers/video/cyber2000fb.c
@@ -502,6 +502,9 @@ static void cyber2000fb_set_timing(struc
 	cyber2000_grphw(0xb9, 0x80, cfb);
 	cyber2000_grphw(0xb9, 0x00, cfb);
 
+	/* wait (for the PLL?) to avoid palette corruption at higher clocks */
+	msleep(1000);
+
 	cfb->ramdac_ctrl = hw->ramdac;
 	cyber2000fb_write_ramdac_ctrl(cfb);
 
_

Patches currently in -mm which might be from linux@rainbow-software.org are

cyber2000fb-avoid-palette-corruption-at-higher-clocks.patch


                 reply	other threads:[~2010-08-23 19:33 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201008231933.o7NJXJ9R010514@imap1.linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@rainbow-software.org \
    --cc=mm-commits@vger.kernel.org \
    --cc=rmk@arm.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.