All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@redhat.com>
To: David Miller <davem@davemloft.net>
Cc: chris.snook@gmail.com, hagen@jauu.net, eric.dumazet@gmail.com,
	netdev@vger.kernel.org, ilpo.jarvinen@helsinki.fi,
	shemminger@vyatta.com
Subject: Re: [PATCH] tcp: make TCP quick ACK behavior modifiable
Date: Mon, 23 Aug 2010 20:17:26 -0300	[thread overview]
Message-ID: <20100823231726.GK2973@ghostprotocols.net> (raw)
In-Reply-To: <20100823.152330.184822588.davem@davemloft.net>

Em Mon, Aug 23, 2010 at 03:23:30PM -0700, David Miller escreveu:
> From: Chris Snook <chris.snook@gmail.com>
> Date: Mon, 23 Aug 2010 18:19:45 -0400
> 
> > Just because we've allowed stupid TCP sysctls in the past does not
> > mean we should continue to do so now.  We recently made delayed ack a
> > per-route tunable, so consistency would suggest we do the same here.
> > Per-route tunables are more flexible, and as with the delayed ack
> > patch, there are use cases where that granularity gives a clear
> > advantage over a sysctl.  For example, you may want to disable quick
> > ack on a high-MTU path and enable it on a low-MTU path.
> > 
> > If you need a hint for how to implement the per-route tunable, look
> > for the delayed ack patch from early 2009.
> 
> I completely agree with Chris that this should be a per-route rather
> than a global sysctl tunable.

My first impression was not so strong as to participate, if every
tunable gets a knob, well, we'd be flying concordes in no time.

But even with such reaction, I thought that if a tunable would be
interesting to have would be a setsockopt one, that knowledgeable,
performance/latency hungry actors would jump into as if they were really
hungry.

And yes, that knob I worked on got lost along the way, I guess I have to
think again about it and submit.

- Arnaldo

  parent reply	other threads:[~2010-08-23 23:18 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-23 19:00 [PATCH] tcp: make TCP quick ACK behavior modifiable Hagen Paul Pfeifer
2010-08-23 19:14 ` Stephen Hemminger
2010-08-23 19:57   ` Hagen Paul Pfeifer
2010-08-23 20:08   ` Hagen Paul Pfeifer
2010-08-23 21:21     ` David Miller
2010-08-23 21:51       ` Hagen Paul Pfeifer
2010-08-23 22:04         ` Chris Snook
2010-08-23 22:16         ` David Miller
2010-08-23 20:44 ` Eric Dumazet
2010-08-23 20:49   ` Hagen Paul Pfeifer
2010-08-23 21:10   ` Chris Snook
2010-08-23 22:01     ` Hagen Paul Pfeifer
2010-08-23 22:19       ` Chris Snook
2010-08-23 22:23         ` David Miller
2010-08-23 22:26           ` Hagen Paul Pfeifer
2010-08-23 23:17           ` Arnaldo Carvalho de Melo [this message]
2010-08-23 23:18             ` Arnaldo Carvalho de Melo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100823231726.GK2973@ghostprotocols.net \
    --to=acme@redhat.com \
    --cc=chris.snook@gmail.com \
    --cc=davem@davemloft.net \
    --cc=eric.dumazet@gmail.com \
    --cc=hagen@jauu.net \
    --cc=ilpo.jarvinen@helsinki.fi \
    --cc=netdev@vger.kernel.org \
    --cc=shemminger@vyatta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.