From: Dave Chinner <david@fromorbit.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: David Rientjes <rientjes@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
Neil Brown <neilb@suse.de>, Alasdair G Kergon <agk@redhat.com>,
Chris Mason <chris.mason@oracle.com>,
Steven Whitehouse <swhiteho@redhat.com>,
Jens Axboe <jaxboe@fusionio.com>, Jan Kara <jack@suse.cz>,
Frederic Weisbecker <fweisbec@gmail.com>,
linux-raid@vger.kernel.org, linux-btrfs@vger.kernel.org,
cluster-devel@redhat.com, linux-ext4@vger.kernel.org,
reiserfs-devel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [patch 1/5] mm: add nofail variants of kmalloc kcalloc and kzalloc
Date: Tue, 24 Aug 2010 23:55:22 +1000 [thread overview]
Message-ID: <20100824135522.GK31488@dastard> (raw)
In-Reply-To: <1282656558.2605.2742.camel@laptop>
On Tue, Aug 24, 2010 at 03:29:18PM +0200, Peter Zijlstra wrote:
> On Tue, 2010-08-24 at 03:50 -0700, David Rientjes wrote:
> > These were added as helper functions for documentation and auditability.
> > No future callers should be added.
>
> git grep GFP_NOFAIL isn't auditable enough?
>
> might as well declare these functions depricated if you really want to
> do this.
Also, if you are going to add tight loops, you might want to put a
backoff in the loops like "congestion_wait(BLK_RW_ASYNC, HZ/50);" so
that they don't spin....
FWIW, in all this "allocations can't fail" churn, no one has noticed
that XFS has been doing these "allocations can't fail" loop in
kmem_alloc() and kmem_zone_alloc(), well, forever. I can't ever
remember seeing it report a potential deadlock, though....
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2010-08-24 13:55 UTC|newest]
Thread overview: 87+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-24 10:50 [patch 1/5] mm: add nofail variants of kmalloc kcalloc and kzalloc David Rientjes
2010-08-24 10:50 ` [patch 2/5] mm: add nofail variant of kmem_cache_zalloc David Rientjes
2010-08-24 10:50 ` [patch 3/5] fs: add nofail variant of alloc_buffer_head David Rientjes
2010-08-24 12:17 ` [Cluster-devel] " Jan Kara
2010-08-24 12:17 ` Jan Kara
2010-08-24 10:50 ` [patch 4/5] btrfs: add nofail variant of set_extent_dirty David Rientjes
2010-08-24 13:30 ` Peter Zijlstra
2010-08-24 10:50 ` [patch 5/5] ntfs: remove dependency on __GFP_NOFAIL David Rientjes
2010-08-24 12:15 ` [Cluster-devel] [patch 1/5] mm: add nofail variants of kmalloc kcalloc and kzalloc Jan Kara
2010-08-24 12:15 ` Jan Kara
2010-08-24 13:29 ` Peter Zijlstra
2010-08-24 13:33 ` Jens Axboe
2010-08-24 20:11 ` David Rientjes
2010-08-24 20:11 ` David Rientjes
2010-08-25 11:24 ` Ted Ts'o
2010-08-25 11:35 ` Peter Zijlstra
2010-08-25 11:57 ` Ted Ts'o
2010-08-25 12:48 ` Peter Zijlstra
2010-08-25 12:52 ` Peter Zijlstra
2010-08-25 13:20 ` Theodore Tso
2010-08-25 13:31 ` Peter Zijlstra
2010-08-25 20:43 ` David Rientjes
2010-08-25 20:55 ` Peter Zijlstra
2010-08-25 21:11 ` David Rientjes
2010-08-25 21:27 ` Peter Zijlstra
2010-08-25 23:11 ` David Rientjes
2010-08-26 0:19 ` Ted Ts'o
2010-08-26 0:30 ` David Rientjes
2010-08-26 0:30 ` David Rientjes
2010-08-26 1:48 ` Ted Ts'o
2010-08-26 3:09 ` David Rientjes
2010-08-26 3:09 ` David Rientjes
2010-08-26 7:06 ` Dave Chinner
2010-08-26 8:29 ` Peter Zijlstra
2010-08-26 3:09 ` David Rientjes
2010-08-26 3:09 ` David Rientjes
2010-08-26 3:09 ` David Rientjes
2010-08-26 6:38 ` Dave Chinner
2010-08-26 6:38 ` Dave Chinner
2010-08-26 6:38 ` Dave Chinner
2010-08-26 6:38 ` Dave Chinner
2010-08-26 6:38 ` Dave Chinner
2010-08-26 0:30 ` David Rientjes
2010-08-26 0:30 ` David Rientjes
2010-08-26 0:30 ` David Rientjes
2010-08-25 13:34 ` Peter Zijlstra
2010-08-25 13:24 ` Dave Chinner
2010-08-25 13:35 ` Peter Zijlstra
2010-08-25 20:53 ` Ted Ts'o
2010-08-25 20:59 ` David Rientjes
2010-08-25 20:59 ` David Rientjes
2010-08-25 20:59 ` David Rientjes
2010-08-25 20:59 ` David Rientjes
2010-08-25 20:59 ` David Rientjes
2010-08-25 21:35 ` Peter Zijlstra
2010-08-25 20:58 ` David Rientjes
2010-08-25 21:11 ` Christoph Lameter
2010-08-25 21:21 ` Peter Zijlstra
2010-08-25 21:23 ` David Rientjes
2010-08-25 21:35 ` Christoph Lameter
2010-08-25 23:05 ` David Rientjes
2010-08-26 1:30 ` Christoph Lameter
2010-08-26 3:12 ` David Rientjes
2010-08-26 14:16 ` Christoph Lameter
2010-08-26 22:31 ` David Rientjes
2010-08-26 0:09 ` Dave Chinner
2010-08-25 14:13 ` Peter Zijlstra
2010-08-24 13:55 ` Dave Chinner [this message]
2010-08-24 14:03 ` Peter Zijlstra
2010-08-24 20:12 ` David Rientjes
2010-08-24 20:08 ` David Rientjes
2010-09-02 1:02 ` [patch v2 " David Rientjes
2010-09-02 1:03 ` [patch v2 2/5] mm: add nofail variant of kmem_cache_zalloc David Rientjes
2010-09-02 1:03 ` [patch v2 3/5] fs: add nofail variant of alloc_buffer_head David Rientjes
2010-09-02 1:03 ` [patch v2 4/5] btrfs: add nofail variant of set_extent_dirty David Rientjes
2010-09-02 1:03 ` [patch v2 5/5] ntfs: remove dependency on __GFP_NOFAIL David Rientjes
2010-09-02 9:08 ` Anton Altaparmakov
2010-09-05 22:55 ` David Rientjes
2010-09-02 7:59 ` [patch v2 1/5] mm: add nofail variants of kmalloc kcalloc and kzalloc Jiri Slaby
2010-09-02 14:51 ` [Cluster-devel] " Jan Kara
2010-09-02 14:51 ` Jan Kara
2010-09-02 21:15 ` [Cluster-devel] " Neil Brown
2010-09-02 21:15 ` Neil Brown
2010-09-02 21:15 ` Neil Brown
2010-09-05 23:03 ` David Rientjes
2010-09-05 23:01 ` David Rientjes
2010-09-06 9:05 ` David Rientjes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100824135522.GK31488@dastard \
--to=david@fromorbit.com \
--cc=agk@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=chris.mason@oracle.com \
--cc=cluster-devel@redhat.com \
--cc=fweisbec@gmail.com \
--cc=jack@suse.cz \
--cc=jaxboe@fusionio.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=neilb@suse.de \
--cc=peterz@infradead.org \
--cc=reiserfs-devel@vger.kernel.org \
--cc=rientjes@google.com \
--cc=swhiteho@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.