All of lore.kernel.org
 help / color / mirror / Atom feed
From: don.mullis@gmail.com
To: Artem.Bityutskiy@nokia.com, aelder@sgi.com, airlied@linux.ie
Cc: stable@kernel.org, linux-kernel@vger.kernel.org,
	Don Mullis <don.mullis@gmail.com>
Subject: [PATCH 05/10] lib/list_sort: selftest: improve printk wording
Date: Tue, 24 Aug 2010 08:47:26 -0700	[thread overview]
Message-ID: <20100824154858.588047317@gmail.com> (raw)
In-Reply-To: 20100824154721.995117660@gmail.com

[-- Attachment #1: lib_list_sort_-selftest_-improve-printk-wording-2.patch --]
[-- Type: text/plain, Size: 2308 bytes --]

From: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>

Start boot printk's with "list_sort_test:" prefix to make it obvious
for users where the messages come from; other wording improvements.

Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
Signed-off-by: Don Mullis <don.mullis@gmail.com>
---
 lib/list_sort.c |   18 ++++++++----------
 1 file changed, 8 insertions(+), 10 deletions(-)

Index: linux-next/lib/list_sort.c
===================================================================
--- linux-next.orig/lib/list_sort.c	2010-08-23 22:51:19.703177580 -0700
+++ linux-next/lib/list_sort.c	2010-08-23 23:01:55.854177312 -0700
@@ -167,14 +167,14 @@ static int __init list_sort_test(void)
 	struct list_head head;
 	struct list_head *cur, *tmp;
 
-	printk(KERN_DEBUG "testing list_sort()\n");
+	printk(KERN_DEBUG "list_sort_test: starting\n");
 
 	cur = &head;
 	for (i = 0; i < LIST_SORT_TEST_LENGTH; i++) {
 		struct debug_el *el = kmalloc(sizeof(*el), GFP_KERNEL);
 		if (!el) {
-			printk(KERN_ERR "cannot	allocate memory -- "
-					"testing aborted\n");
+			printk(KERN_ERR "list_sort_test: cannot	allocate memory"
+					" -- testing aborted\n");
 			goto exit;
 		}
 		 /* force some equivalencies */
@@ -195,26 +195,24 @@ static int __init list_sort_test(void)
 		struct debug_el *el_next;
 		int cmp_result = cmp(NULL, cur, cur->next);
 		if (cur->next->prev != cur) {
-			printk(KERN_ERR "list_sort() returned "
-					"a corrupted list!\n");
+			printk(KERN_ERR "list_sort_test: list corrupted\n");
 			goto exit;
 		}
 		if (cmp_result > 0) {
-			printk(KERN_ERR "list_sort() failed to sort!\n");
+			printk(KERN_ERR "list_sort_test: failed to sort\n");
 			goto exit;
 		}
 		el = container_of(cur, struct debug_el, list);
 		el_next = container_of(cur->next, struct debug_el, list);
 		if (cmp_result == 0 && el->serial >= el_next->serial) {
-			printk(KERN_ERR "list_sort() failed to preserve order "
-					"of equivalent elements!\n");
+			printk(KERN_ERR "list_sort_test: failed to preserve"
+					" order of equivalent elements\n");
 			goto exit;
 		}
 		count++;
 	}
 	if (count != LIST_SORT_TEST_LENGTH) {
-		printk(KERN_ERR "list_sort() returned list of "
-				"different length!\n");
+		printk(KERN_ERR "list_sort_test: list length changed\n");
 		goto exit;
 	}
 	err = 0;


  parent reply	other threads:[~2010-08-24 16:02 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-24 15:47 [PATCH 00/10] lib/list_sort: strengthen self-test to expose a bug, then fix the bug don.mullis
2010-08-24 15:47 ` [PATCH 01/10] lib/list_sort: selftest: enabled with CONFIG_TEST_LIST_SORT don.mullis
2010-08-24 15:47 ` [PATCH 02/10] lib/list_sort: selftest: use more appropriate printk levels don.mullis
2010-08-24 15:47 ` [PATCH 03/10] lib/list_sort: selftest: cleanups: use random32(), rename variables don.mullis
2010-08-24 15:47 ` [PATCH 04/10] lib/list_sort: selftest: permit normal boot after test failure don.mullis
2010-08-24 15:47 ` don.mullis [this message]
2010-08-24 15:47 ` [PATCH 06/10] lib/list_sort: selftest: cleanups: use signed arithmetic, noinline don.mullis
2010-08-24 15:47 ` [PATCH 07/10] lib/list_sort: selftest: strengthen checking to expose corner case don.mullis
2010-08-24 15:47 ` [PATCH 08/10] lib/list_sort: selftest: stress algorithm with lists of various lengths don.mullis
2010-08-24 15:47 ` [PATCH 09/10] lib/list_sort: improve list_sort() function documentation don.mullis
2010-08-24 15:47 ` [PATCH 10/10] lib/list_sort: fix bad args in callback to clients cmp() don.mullis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100824154858.588047317@gmail.com \
    --to=don.mullis@gmail.com \
    --cc=Artem.Bityutskiy@nokia.com \
    --cc=aelder@sgi.com \
    --cc=airlied@linux.ie \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stable@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.