From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Subject: Re: [PATCH 3/3] h1940: implement mmc_power function Date: Tue, 24 Aug 2010 16:41:57 +0200 Message-ID: <201008241641.57621.marek.vasut@gmail.com> References: <1282230003-2020-1-git-send-email-anarsoul@gmail.com> <201008241601.12355.marek.vasut@gmail.com> <201008241721.11669.anarsoul@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <201008241721.11669.anarsoul@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Vasily Khoruzhick Cc: "Arnaud Patard (Rtp)" , linux-samsung-soc@vger.kernel.org, Ben Dooks , linux-arm-kernel@lists.infradead.org List-Id: linux-samsung-soc@vger.kernel.org RG5lIMOadCAyNC4gc3JwbmEgMjAxMCAxNjoyMTowMSBWYXNpbHkgS2hvcnV6aGljayBuYXBzYWwo YSk6Cj4g0JIg0YHQvtC+0LHRidC10L3QuNC4INC+0YIgMjQg0LDQstCz0YPRgdGC0LAgMjAxMCAx NzowMToxMiDQsNCy0YLQvtGAIE1hcmVrIFZhc3V0INC90LDQv9C40YHQsNC7Ogo+ID4gcHJfZXJy KCkgYW5kIGRvbid0IHByb2JlIHRoZSBkZXZpY2UgZm9yIHdoaWNoIHlvdSBjb3VsZG4ndCByZXF1 ZXN0IEdQSU8uCj4gCj4gV2VsbCwgaGFuZGxpbmcgdGhvc2UgZXJyb3JzIGluIG1hY2hpbmUgaW5p dCBmdW5jdGlvbnMgZG9lc24ndCBtYWtlIHNlbnNlLgo+IFBEQSBpcyBub3QgdXNhYmxlIHdpdGhv dXQgYmFzaWMgaGFyZHdhcmUuCj4gCllvdSBjYW4gdXNlIFBEQSB3aXRob3V0IExDRCBmb3IgZXhh bXBsZSAodGhlcmUgYXJlIHN1Y2ggcGVvcGxlLCB0cnVzdCBtZSkuIFNvLCAKdGhpcyBjb21tZW50 IHJlYWxseSBpc24ndCB0b28gdmFsaWQuIFlvdSBjYW4gYWxzbyB1c2UgUERBIHdpdGhvdXQgTU1D IHN1cHBvcnQsIAp5b3Ugc3RpbGwgaGF2ZSBvbmJvYXJkIGZsYXNoLCBldGMuIGV0Yy4KCkNoZWVy cwoKPiBSZWdhcmRzCj4gVmFzaWx5CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2Vy bmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1h bi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: marek.vasut@gmail.com (Marek Vasut) Date: Tue, 24 Aug 2010 16:41:57 +0200 Subject: [PATCH 3/3] h1940: implement mmc_power function In-Reply-To: <201008241721.11669.anarsoul@gmail.com> References: <1282230003-2020-1-git-send-email-anarsoul@gmail.com> <201008241601.12355.marek.vasut@gmail.com> <201008241721.11669.anarsoul@gmail.com> Message-ID: <201008241641.57621.marek.vasut@gmail.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Dne ?t 24. srpna 2010 16:21:01 Vasily Khoruzhick napsal(a): > ? ????????? ?? 24 ??????? 2010 17:01:12 ????? Marek Vasut ???????: > > pr_err() and don't probe the device for which you couldn't request GPIO. > > Well, handling those errors in machine init functions doesn't make sense. > PDA is not usable without basic hardware. > You can use PDA without LCD for example (there are such people, trust me). So, this comment really isn't too valid. You can also use PDA without MMC support, you still have onboard flash, etc. etc. Cheers > Regards > Vasily