From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932409Ab0HXWx5 (ORCPT ); Tue, 24 Aug 2010 18:53:57 -0400 Received: from kroah.org ([198.145.64.141]:52130 "EHLO coco.kroah.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756348Ab0HXWxu (ORCPT ); Tue, 24 Aug 2010 18:53:50 -0400 X-Mailbox-Line: From gregkh@clark.site Tue Aug 24 15:25:24 2010 Message-Id: <20100824222524.325938435@clark.site> User-Agent: quilt/0.48-11.2 Date: Tue, 24 Aug 2010 15:24:34 -0700 From: Greg KH To: linux-kernel@vger.kernel.org, stable@kernel.org Cc: stable-review@kernel.org, torvalds@linux-foundation.org, akpm@linux-foundation.org, alan@lxorguk.ukuu.org.uk, Patrick LoPresti , Alasdair G Kergon Subject: [22/59] dm mpath: fix NULL pointer dereference when path parameters missing In-Reply-To: <20100824224625.GA5449@kroah.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2.6.32-stable review patch. If anyone has any objections, please let us know. ------------------ From: Alasdair G Kergon commit 6bbf79a14080a0c61212f53b4b87dc1a99fedf9c upstream. multipath_ctr() forgets to return an error after detecting missing path parameters. Fix this. Signed-off-by: Patrick LoPresti Signed-off-by: Alasdair G Kergon Signed-off-by: Greg Kroah-Hartman --- drivers/md/dm-mpath.c | 1 + 1 file changed, 1 insertion(+) --- a/drivers/md/dm-mpath.c +++ b/drivers/md/dm-mpath.c @@ -691,6 +691,7 @@ static struct priority_group *parse_prio if (as->argc < nr_params) { ti->error = "not enough path parameters"; + r = -EINVAL; goto bad; }