From: Charles Bailey <charles@hashpling.org>
To: David Aguilar <davvid@gmail.com>
Cc: Jonathan Nieder <jrnieder@gmail.com>,
Brian Gernhardt <brian@gernhardtsoftware.com>,
Git List <git@vger.kernel.org>,
Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH v2] t7610 (mergetool): more nitpicks
Date: Wed, 25 Aug 2010 08:56:50 +0100 [thread overview]
Message-ID: <20100825075650.GB18308@hashpling.org> (raw)
In-Reply-To: <20100825074034.GA4058@gmail.com>
On Wed, Aug 25, 2010 at 12:40:38AM -0700, David Aguilar wrote:
> On Tue, Aug 24, 2010 at 07:25:52PM -0500, Jonathan Nieder wrote:
> > - use tabs to indent
> > [...]
>
> Cool. I'd like to do the same to git-mergetool.sh too.
> Until now I've stuck to the existing style.
> My editor is setup to display tabs visually which makes it easy
> for me to emulate existing code but not everyone does that.
>
> Any objections to a patch that replaces the mixed 4-space+tab
> indents with pure tabs?
Just the same objection as the last time:
http://thread.gmane.org/gmane.comp.version-control.git/115069/focus=115192
We've already tidyied up mergetool to be consistent, I don't see what
touching 90% of the lines achieves other than getting yourself
'blamed' for everything in mergetool.
Charles.
next prev parent reply other threads:[~2010-08-25 7:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-24 2:37 [PATCH] t7610: cd inside subshell instead of around Brian Gernhardt
2010-08-24 3:05 ` Jonathan Nieder
2010-08-24 3:51 ` Brian Gernhardt
2010-08-24 5:03 ` Jonathan Nieder
2010-08-25 0:25 ` [PATCH v2] t7610 (mergetool): more nitpicks Jonathan Nieder
2010-08-25 7:40 ` David Aguilar
2010-08-25 7:56 ` Charles Bailey [this message]
2010-08-26 8:38 ` David Aguilar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100825075650.GB18308@hashpling.org \
--to=charles@hashpling.org \
--cc=brian@gernhardtsoftware.com \
--cc=davvid@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.