From: Sitsofe Wheeler <sitsofe@yahoo.com>
To: Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org,
torvalds@linux-foundation.org
Subject: Re: [PATCH] drm/i915: fix vblank wait test condition
Date: Wed, 25 Aug 2010 09:13:36 +0100 [thread overview]
Message-ID: <20100825081336.GA30504@sucs.org> (raw)
In-Reply-To: <20100824113116.249c13b4@virtuousgeek.org>
On Tue, Aug 24, 2010 at 11:31:16AM -0700, Jesse Barnes wrote:
> When converting this to the new wait_for macro I inverted the wait
> condition, which causes all sorts of problems. So correct it to fix
> several failures caused by the bad wait (flickering, bad output
> detection, tearing, etc.).
Further testing has shown this fixed one set of cases where strange
behaviour happened on my EeePC but there are other triggers. I've found
the following:
With this patch booting without a battery in the machine will lead to a
stable system without lots of errors appearing in dmesg (just one
"Insufficient FIFO" at boot). Doing "watch --differences=cumulative
xrandr" always shows the same outputs. VT switching occasionally causes
the occasional "*ERROR* vblank wait timed out" message. However doing a
suspend/resume brings back all the problems, dmesg starts filling up
with FIFO errors and xrandr starts reporting different outputs every
time it is called. Additionally, booting with a battery inside the
machine at boot will always lead to the quirky behaviour too.
--
Sitsofe | http://sucs.org/~sits/
prev parent reply other threads:[~2010-08-25 8:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-24 18:31 [PATCH] drm/i915: fix vblank wait test condition Jesse Barnes
2010-08-25 8:13 ` Sitsofe Wheeler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100825081336.GA30504@sucs.org \
--to=sitsofe@yahoo.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jbarnes@virtuousgeek.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.