From: Marcelo Tosatti <mtosatti@redhat.com>
To: Avi Kivity <avi@redhat.com>
Cc: kvm@vger.kernel.org
Subject: Re: [PATCH 2/8] KVM: x86 emulator: simplify ALU block (opcodes 00-3F) decode flags
Date: Wed, 25 Aug 2010 16:39:22 -0300 [thread overview]
Message-ID: <20100825193922.GA31337@amt.cnet> (raw)
In-Reply-To: <1282561577-24491-3-git-send-email-avi@redhat.com>
On Mon, Aug 23, 2010 at 02:06:11PM +0300, Avi Kivity wrote:
> Use the new byte/word dual opcode decode.
>
> Signed-off-by: Avi Kivity <avi@redhat.com>
> ---
> arch/x86/kvm/emulate.c | 40 ++++++++++++++++------------------------
> 1 files changed, 16 insertions(+), 24 deletions(-)
>
> diff --git a/arch/x86/kvm/emulate.c b/arch/x86/kvm/emulate.c
> index 152654e..79a5f81 100644
> --- a/arch/x86/kvm/emulate.c
> +++ b/arch/x86/kvm/emulate.c
> @@ -2370,42 +2370,34 @@ static struct group_dual group9 = { {
>
> static struct opcode opcode_table[256] = {
> /* 0x00 - 0x07 */
> - D(ByteOp | DstMem | SrcReg | ModRM | Lock), D(DstMem | SrcReg | ModRM | Lock),
> - D(ByteOp | DstReg | SrcMem | ModRM), D(DstReg | SrcMem | ModRM),
> - D(ByteOp | DstAcc | SrcImm), D(DstAcc | SrcImm),
> + D2bv(DstMem | SrcReg | ModRM | Lock), D2bv(DstReg | SrcMem | ModRM),
> + D2bv(DstAcc | SrcImm),
> D(ImplicitOps | Stack | No64), D(ImplicitOps | Stack | No64),
> /* 0x08 - 0x0F */
> - D(ByteOp | DstMem | SrcReg | ModRM | Lock), D(DstMem | SrcReg | ModRM | Lock),
> - D(ByteOp | DstReg | SrcMem | ModRM), D(DstReg | SrcMem | ModRM),
> - D(ByteOp | DstAcc | SrcImm), D(DstAcc | SrcImm),
> + D2bv(DstMem | SrcReg | ModRM | Lock), D2bv(DstReg | SrcMem | ModRM),
> + D2bv(DstAcc | SrcImm),
> D(ImplicitOps | Stack | No64), N,
> /* 0x10 - 0x17 */
> - D(ByteOp | DstMem | SrcReg | ModRM | Lock), D(DstMem | SrcReg | ModRM | Lock),
> - D(ByteOp | DstReg | SrcMem | ModRM), D(DstReg | SrcMem | ModRM),
> - D(ByteOp | DstAcc | SrcImm), D(DstAcc | SrcImm),
> + D2bv(DstMem | SrcReg | ModRM | Lock), D2bv(DstReg | SrcMem | ModRM),
> + D2bv(DstAcc | SrcImm),
> D(ImplicitOps | Stack | No64), D(ImplicitOps | Stack | No64),
> /* 0x18 - 0x1F */
> - D(ByteOp | DstMem | SrcReg | ModRM | Lock), D(DstMem | SrcReg | ModRM | Lock),
> - D(ByteOp | DstReg | SrcMem | ModRM), D(DstReg | SrcMem | ModRM),
> - D(ByteOp | DstAcc | SrcImm), D(DstAcc | SrcImm),
> + D2bv(DstMem | SrcReg | ModRM | Lock), D2bv(DstReg | SrcMem | ModRM),
> + D2bv(DstAcc | SrcImm),
> D(ImplicitOps | Stack | No64), D(ImplicitOps | Stack | No64),
> /* 0x20 - 0x27 */
> - D(ByteOp | DstMem | SrcReg | ModRM | Lock), D(DstMem | SrcReg | ModRM | Lock),
> - D(ByteOp | DstReg | SrcMem | ModRM), D(DstReg | SrcMem | ModRM),
> - D(ByteOp | DstAcc | SrcImmByte), D(DstAcc | SrcImm), N, N,
> + D2bv(DstMem | SrcReg | ModRM | Lock), D2bv(DstReg | SrcMem | ModRM),
> + D2bv(DstAcc | SrcImmByte), N, N,
SrcImm? opcode 0x25...
next prev parent reply other threads:[~2010-08-25 19:51 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-23 11:06 [PATCH 0/8] Simplify byte/word opcode pair decode Avi Kivity
2010-08-23 11:06 ` [PATCH 1/8] KVM: x86 emulator: support byte/word opcode pairs Avi Kivity
2010-08-23 11:06 ` [PATCH 2/8] KVM: x86 emulator: simplify ALU block (opcodes 00-3F) decode flags Avi Kivity
2010-08-25 19:39 ` Marcelo Tosatti [this message]
2010-08-26 8:26 ` Avi Kivity
2010-08-23 11:06 ` [PATCH 3/8] KVM: x86 emulator: simplify string instruction " Avi Kivity
2010-08-23 11:06 ` [PATCH 4/8] KVM: x86 emulator: simplify instruction decode flags for opcodes 80-8F Avi Kivity
2010-08-23 11:06 ` [PATCH 5/8] KVM: x86 emulator: simplify instruction decode flags for opcodes A0-AF Avi Kivity
2010-08-23 11:06 ` [PATCH 6/8] KVM: x86 emulator: simplify instruction decode flags for opcodes C0-DF Avi Kivity
2010-08-23 11:06 ` [PATCH 7/8] KVM: x86 emulator: simplify instruction decode flags for opcodes E0-FF Avi Kivity
2010-08-23 13:33 ` Gleb Natapov
2010-08-23 13:46 ` Avi Kivity
2010-08-23 13:56 ` Gleb Natapov
2010-08-23 11:06 ` [PATCH 8/8] KVM: x86 emulator: simplify instruction decode flags for opcodes 0F 00-FF Avi Kivity
2010-08-23 13:29 ` [PATCH 0/8] Simplify byte/word opcode pair decode Paolo Bonzini
2010-08-23 13:48 ` Avi Kivity
2010-08-23 14:04 ` Paolo Bonzini
2010-08-23 14:13 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100825193922.GA31337@amt.cnet \
--to=mtosatti@redhat.com \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.