From mboxrd@z Thu Jan  1 00:00:00 1970
From: Olaf Hering <olaf@aepfle.de>
Subject: Re: paged granttable entries
Date: Thu, 26 Aug 2010 16:50:24 +0200
Message-ID: <20100826145024.GA7338@aepfle.de>
References: <20100826121355.GA6254@aepfle.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Return-path: <xen-devel-bounces@lists.xensource.com>
Content-Disposition: inline
In-Reply-To: <20100826121355.GA6254@aepfle.de>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Patrick Colp <pjcolp@cs.ubc.ca>
Cc: xen-devel@lists.xensource.com
List-Id: xen-devel@lists.xenproject.org


Patrick,

while looking for other usage of p2m_mem_paging_populate(), I found two
calls in __gnttab_copy(). They set the error gnttab_copy_t->status to
-ENOENT.
Should this better be something from the GNTST_* namespace? I did not
see a check for -ENOENT "on the other side".

At least the kernel drivers in SLES11 do only check for GNTST_okay and
GNTST_eagain and GNTST_bad_page.


And a quick search for op->status usage shows a mix of GNTST_* and
status != 0. While it may not make much difference, perhaps there should
be some translation between the granttable error namespace and other
namespaces.


Olaf