Re: [PATCH 1/1] drivers/misc/akm8975: Add compass sensor driver

[Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>]

On Thu, 26 Aug 2010 19:10:37 -0700, Andrew Morton wrote:
> > From: Andrew Chew <achew-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
> > 
> > This is for the Asahi Kasei's I2C compass sensor AK8975.
> > 
> > Signed-off-by: Andrew Chew <achew-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
> > ---
> >  drivers/misc/Kconfig    |    8 +
> >  drivers/misc/Makefile   |    1 +
> >  drivers/misc/akm8975.c  |  670 +++++++++++++++++++++++++++++++++++++++++++++++
> >  include/linux/akm8975.h |   87 ++++++
> >  4 files changed, 766 insertions(+), 0 deletions(-)
> >  create mode 100644 drivers/misc/akm8975.c
> >  create mode 100644 include/linux/akm8975.h
> > 
> > diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig
> > index 26386a9..9bb3d03 100644
> > --- a/drivers/misc/Kconfig
> > +++ b/drivers/misc/Kconfig
> > @@ -304,6 +304,14 @@ config SENSORS_TSL2550
> >  	  This driver can also be built as a module.  If so, the module
> >  	  will be called tsl2550.
> >  
> > +config SENSORS_AK8975
> > +	tristate "AK8975 compass support"
> > +	default n
> > +	depends on I2C
> > +	help
> > +	  If you say yes here you get support for Asahi Kasei's
> > +	  orientation sensor AK8975.
> 
> Should it be in drivers/hwmon?
> 
> Perhaps not, given that drivers/misc/hmc6352.c is in drivers/misc/

No, this driver doesn't implement any standard hwmon attribute, so it
doesn't belong to drivers/hwmon. drivers/misc/ seems OK, until either
the IIO subsystem emerges, or someone creates a compass subsystem.

-- 
Jean Delvare