From mboxrd@z Thu Jan 1 00:00:00 1970 From: Robert Richter Subject: Re: [PATCH V2 3/4] oprofile: Abstract the perf-events backend Date: Fri, 27 Aug 2010 14:59:56 +0200 Message-ID: <20100827125956.GK22783@erda.amd.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-sh-owner@vger.kernel.org To: Matt Fleming Cc: "linux-kernel@vger.kernel.org" , Will Deacon , Paul Mundt , Russell King , "linux-arm-kernel@lists.infradead.org" , "linux-sh@vger.kernel.org" , Peter Zijlstra , Ingo Molnar , Frederic Weisbecker , Arnaldo Carvalho de Melo , "linux-arch@vger.kernel.org" List-Id: linux-arch.vger.kernel.org On 26.08.10 15:09:18, Matt Fleming wrote: > Move the perf-events backend from arch/arm/oprofile into > drivers/oprofile so that the code can be shared between architectures. > > This allows each architecture to maintain only a single copy of the > PMU accessor functions instead of one for both perf and OProfile. It > also becomes possible for other architectures to delete much of their > OProfile code in favour of the common code now available in > drivers/oprofile/oprofile_perf.c. > > Signed-off-by: Matt Fleming > --- > arch/arm/oprofile/Makefile | 4 + > arch/arm/oprofile/common.c | 215 +++----------------------------------- > drivers/oprofile/oprofile_perf.c | 209 ++++++++++++++++++++++++++++++++++++ > include/linux/oprofile.h | 12 ++ > 4 files changed, 242 insertions(+), 198 deletions(-) > create mode 100644 drivers/oprofile/oprofile_perf.c Could we split this patch in 2 for better review? One that only moves the code and a 2nd that changes it. -Robert -- Advanced Micro Devices, Inc. Operating System Research Center From mboxrd@z Thu Jan 1 00:00:00 1970 From: Robert Richter Date: Fri, 27 Aug 2010 12:59:56 +0000 Subject: Re: [PATCH V2 3/4] oprofile: Abstract the perf-events backend Message-Id: <20100827125956.GK22783@erda.amd.com> List-Id: References: In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Matt Fleming Cc: "linux-kernel@vger.kernel.org" , Will Deacon , Paul Mundt , Russell King , "linux-arm-kernel@lists.infradead.org" , "linux-sh@vger.kernel.org" , Peter Zijlstra , Ingo Molnar , Frederic Weisbecker , Arnaldo Carvalho de Melo , "linux-arch@vger.kernel.org" On 26.08.10 15:09:18, Matt Fleming wrote: > Move the perf-events backend from arch/arm/oprofile into > drivers/oprofile so that the code can be shared between architectures. > > This allows each architecture to maintain only a single copy of the > PMU accessor functions instead of one for both perf and OProfile. It > also becomes possible for other architectures to delete much of their > OProfile code in favour of the common code now available in > drivers/oprofile/oprofile_perf.c. > > Signed-off-by: Matt Fleming > --- > arch/arm/oprofile/Makefile | 4 + > arch/arm/oprofile/common.c | 215 +++----------------------------------- > drivers/oprofile/oprofile_perf.c | 209 ++++++++++++++++++++++++++++++++++++ > include/linux/oprofile.h | 12 ++ > 4 files changed, 242 insertions(+), 198 deletions(-) > create mode 100644 drivers/oprofile/oprofile_perf.c Could we split this patch in 2 for better review? One that only moves the code and a 2nd that changes it. -Robert -- Advanced Micro Devices, Inc. Operating System Research Center From mboxrd@z Thu Jan 1 00:00:00 1970 From: robert.richter@amd.com (Robert Richter) Date: Fri, 27 Aug 2010 14:59:56 +0200 Subject: [PATCH V2 3/4] oprofile: Abstract the perf-events backend In-Reply-To: References: Message-ID: <20100827125956.GK22783@erda.amd.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 26.08.10 15:09:18, Matt Fleming wrote: > Move the perf-events backend from arch/arm/oprofile into > drivers/oprofile so that the code can be shared between architectures. > > This allows each architecture to maintain only a single copy of the > PMU accessor functions instead of one for both perf and OProfile. It > also becomes possible for other architectures to delete much of their > OProfile code in favour of the common code now available in > drivers/oprofile/oprofile_perf.c. > > Signed-off-by: Matt Fleming > --- > arch/arm/oprofile/Makefile | 4 + > arch/arm/oprofile/common.c | 215 +++----------------------------------- > drivers/oprofile/oprofile_perf.c | 209 ++++++++++++++++++++++++++++++++++++ > include/linux/oprofile.h | 12 ++ > 4 files changed, 242 insertions(+), 198 deletions(-) > create mode 100644 drivers/oprofile/oprofile_perf.c Could we split this patch in 2 for better review? One that only moves the code and a 2nd that changes it. -Robert -- Advanced Micro Devices, Inc. Operating System Research Center