From: Mike Snitzer <snitzer@redhat.com>
To: Tejun Heo <tj@kernel.org>
Cc: jaxboe@fusionio.com, k-ueda@ct.jp.nec.com,
j-nomura@ce.jp.nec.com, jamie@shareable.org,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-raid@vger.kernel.org, hch@lst.de
Subject: Re: [PATCH 1/4] block: make __blk_rq_prep_clone() copy most command flags
Date: Fri, 27 Aug 2010 13:57:11 -0400 [thread overview]
Message-ID: <20100827175711.GB23680@redhat.com> (raw)
In-Reply-To: <1282929060-23663-2-git-send-email-tj@kernel.org>
On Fri, Aug 27 2010 at 1:10pm -0400,
Tejun Heo <tj@kernel.org> wrote:
> Currently __blk_rq_prep_clone() copies only REQ_WRITE and REQ_DISCARD.
> There's no reason to omit other command flags and REQ_FUA needs to be
> copied to implement FUA support in request-based dm.
>
> REQ_COMMON_MASK which specifies flags to be copied from bio to request
> already identifies all the command flags. Define REQ_CLONE_MASK to be
> the same as REQ_COMMON_MASK for clarity and make __blk_rq_prep_clone()
> copy all flags in the mask.
>
> Signed-off-by: Tejun Heo <tj@kernel.org>
Looks great.
Acked-by: Mike Snitzer <snitzer@redhat.com>
next prev parent reply other threads:[~2010-08-27 17:57 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-27 17:10 [PATCHSET 2.6.36-rc2] block, dm: finish REQ_FLUSH/FUA conversion Tejun Heo
2010-08-27 17:10 ` Tejun Heo
2010-08-27 17:10 ` [PATCH 1/4] block: make __blk_rq_prep_clone() copy most command flags Tejun Heo
2010-08-27 17:10 ` Tejun Heo
2010-08-27 17:57 ` Mike Snitzer [this message]
2010-08-27 17:10 ` [PATCH 2/4] dm: implement REQ_FLUSH/FUA support Tejun Heo
2010-08-27 17:10 ` Tejun Heo
2010-08-27 17:10 ` Tejun Heo
2010-08-27 20:24 ` Mike Snitzer
2010-08-27 23:28 ` Tejun Heo
2010-08-28 0:35 ` Mike Snitzer
2010-08-28 0:35 ` Mike Snitzer
2010-08-27 17:10 ` [PATCH 3/4] dm: relax ordering of bio-based flush implementation Tejun Heo
2010-08-27 17:10 ` Tejun Heo
2010-08-27 17:10 ` Tejun Heo
2010-08-27 17:11 ` [PATCH 4/4] block: remove the WRITE_BARRIER flag Tejun Heo
2010-08-27 17:11 ` Tejun Heo
2010-08-27 17:11 ` Tejun Heo
2010-08-27 17:15 ` [PATCHSET 2.6.36-rc2] block, dm: finish REQ_FLUSH/FUA conversion Tejun Heo
2010-08-27 17:15 ` Tejun Heo
2010-08-27 17:15 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100827175711.GB23680@redhat.com \
--to=snitzer@redhat.com \
--cc=hch@lst.de \
--cc=j-nomura@ce.jp.nec.com \
--cc=jamie@shareable.org \
--cc=jaxboe@fusionio.com \
--cc=k-ueda@ct.jp.nec.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.