From: Chris Ball <cjb@laptop.org>
To: Martin Fuzzey <mfuzzey@gmail.com>
Cc: Sascha Hauer <s.hauer@pengutronix.de>,
linux-mmc@vger.kernel.org, Pierre Ossman <pierre@ossman.eu>
Subject: Re: [PATCH V7] mxc : Add i.MX21 support to mxcmmc driver
Date: Fri, 27 Aug 2010 20:14:22 +0100 [thread overview]
Message-ID: <20100827191421.GG20407@void.printf.net> (raw)
In-Reply-To: <20100213153617.21144.68460.stgit@srv002.fuzzey.net>
Hi Martin,
On Sat, Feb 13, 2010 at 04:36:32PM +0100, Martin Fuzzey wrote:
> Even though the i.MX21 SDHC module has the same revision number as the i.MX27
> one there are a few differences!!
> Some interrupt enables are inverted.
> FIFO is only 16 bits wide.
> The argument is written to 2x16bit registers (vs 1x32).
> Interrupts must be acknowledged via the INT_CNTR register.
> Card clock must be enabled for each request.
> For writes DMA must be enabled on command response not before.
>
> Signed-off-by: Martin Fuzzey <mfuzzey@gmail.com>
>
> ---
> Changes from V6 (April 2009):
> Minor stylistic changes suggested by Robby Cai:
> factorize enables in mxcmci_set_int_cntr()
> remove redundant local variable in mxcmci_push() and mxcmci_pull()
> Rebased to 2.6.33-rc8
Looks like this wasn't merged. Are you interested in resubmitting it?
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
One Laptop Per Child
next prev parent reply other threads:[~2010-08-27 19:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-13 15:36 [PATCH V7] mxc : Add i.MX21 support to mxcmmc driver Martin Fuzzey
2010-08-27 19:14 ` Chris Ball [this message]
2010-08-30 15:07 ` Martin Fuzzey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100827191421.GG20407@void.printf.net \
--to=cjb@laptop.org \
--cc=linux-mmc@vger.kernel.org \
--cc=mfuzzey@gmail.com \
--cc=pierre@ossman.eu \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.