All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Ball <cjb@laptop.org>
To: linux-mmc@vger.kernel.org
Cc: "George G. Davis" <gdavis@mvista.com>,
	Ben Dooks <ben-linux@fluff.org>,
	akpm@linux-foundation.org
Subject: [PATCH RESEND] mmc: sdhci: Make consistent use of CONFIG_MMC_DEBUG for "DEBUG"ging
Date: Fri, 27 Aug 2010 20:16:30 +0100	[thread overview]
Message-ID: <20100827191630.GH20407@void.printf.net> (raw)

Hi,

This patch wasn't merged, but still applies -- Andrew, mind taking it?

- Chris.

Date: Thu, 18 Feb 2010 12:32:12 -0500
From: "George G. Davis" <gdavis@mvista.com>

The "6882a8c sdhci: Add better ADMA error reporting" commit added
sdhci_show_adma_error() which is built when DEBUG is defined.
Since we already have CONFIG_MMC_DEBUG used elsewhere in this driver,
may as well make consistent use of that config knob instead.

Signed-off-by: George G. Davis <gdavis@mvista.com>
Cc: Ben Dooks <ben-linux@fluff.org>
---
 drivers/mmc/host/sdhci.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
index c279fbc..6c2978c 100644
--- a/drivers/mmc/host/sdhci.c
+++ b/drivers/mmc/host/sdhci.c
@@ -1398,7 +1398,7 @@ static void sdhci_cmd_irq(struct sdhci_host *host, u32 intmask)
 		sdhci_finish_command(host);
 }
 
-#ifdef DEBUG
+#ifdef CONFIG_MMC_DEBUG
 static void sdhci_show_adma_error(struct sdhci_host *host)
 {
 	const char *name = mmc_hostname(host->mmc);
-- 
1.6.3.3.311.g43dd

-- 
Chris Ball   <cjb@laptop.org>   <http://printf.net/>
One Laptop Per Child

                 reply	other threads:[~2010-08-27 19:16 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100827191630.GH20407@void.printf.net \
    --to=cjb@laptop.org \
    --cc=akpm@linux-foundation.org \
    --cc=ben-linux@fluff.org \
    --cc=gdavis@mvista.com \
    --cc=linux-mmc@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.