From: Tony Lindgren <tony.m.lindgren@gmail.com>
To: "Cousson, Benoit" <b-cousson@ti.com>
Cc: rockefeller <rockefeller.lin@innocomm.com>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
Tony Lindgren <tony@atomide.com>
Subject: Re: [PATCH 2/9] omap: mux: Add new style pin multiplexing code for omap3
Date: Fri, 27 Aug 2010 14:26:41 -0700 [thread overview]
Message-ID: <20100827212640.GE28816@atomide.com> (raw)
In-Reply-To: <4C778455.8050108@ti.com>
* Cousson, Benoit <b-cousson@ti.com> [100827 02:17]:
> On 8/27/2010 4:29 AM, rockefeller wrote:
> >
> >Because "muxname.mode7" in in RAM is modifiable, after function call
> >to function1(), the *pine_mux_name will be "muxname" and therefore when
> >calls to function2() to try to set this pin in mode7 with value 0x0000
> >might be un-expected result.
>
> In theory the pin mux is done once at init time, so I'm not sure
> this case is supposed to happen. Is it a real case?
>
> Anyway, I think that a simple strlcpy(tmp, muxname, 32) in
> omap_mux_init_signal can fix it.
>
> Do you mind submitting a patch to fix that?
Yeah that's a bug, we should not trash the muxname.
Regards,
Tony
next prev parent reply other threads:[~2010-08-27 21:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <S1752576Ab0H0BhI/20100827013708Z+1681@vger.kernel.org>
2010-08-27 2:29 ` RE:[PATCH 2/9] omap: mux: Add new style pin multiplexing code for omap3 rockefeller
2010-08-27 9:24 ` [PATCH " Cousson, Benoit
2010-08-27 21:26 ` Tony Lindgren [this message]
2010-08-30 1:31 ` rockefeller
2010-09-29 0:06 ` Tony Lindgren
2009-12-03 0:21 [PATCH 0/9] Omap mux changes for v2.6.33 merge window, v2 Tony Lindgren
2009-12-03 0:21 ` [PATCH 2/9] omap: mux: Add new style pin multiplexing code for omap3 Tony Lindgren
2009-12-03 0:21 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100827212640.GE28816@atomide.com \
--to=tony.m.lindgren@gmail.com \
--cc=b-cousson@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=rockefeller.lin@innocomm.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.