From: Malahal Naineni <malahal@us.ibm.com>
To: jaxboe@fusionio.com, dm-devel@redhat.com
Subject: Re: [PATCH] block: QUEUE_FLAG_CLUSTER and no_cluster are NOT in sync
Date: Sun, 29 Aug 2010 13:31:50 -0700 [thread overview]
Message-ID: <20100829203149.GC24466@us.ibm.com> (raw)
In-Reply-To: <5e7598cf7714083ffd84.1283104752@malahal>
Here is the missing header:
no_cluster is used by device mapper (may be others) resulting in
multipath devices setting QUEUE_FLAG_CLUSTER flag even though the
underlying devices (e.g. open iscsi virtual adapter) don't support it.
Signed-off-by: Malahal Naineni (malahal@us.ibm.com)
Malahal Naineni [malahal@us.ibm.com] wrote:
> diff -r 8305d08f6ecf -r 5e7598cf7714 drivers/scsi/scsi_lib.c
> --- a/drivers/scsi/scsi_lib.c Wed Aug 25 13:44:33 2010 -0700
> +++ b/drivers/scsi/scsi_lib.c Wed Aug 25 13:44:33 2010 -0700
> @@ -1633,8 +1633,10 @@ struct request_queue *__scsi_alloc_queue
> blk_queue_max_segment_size(q, dma_get_max_seg_size(dev));
>
> /* New queue, no concurrency on queue_flags */
> - if (!shost->use_clustering)
> + if (!shost->use_clustering) {
> queue_flag_clear_unlocked(QUEUE_FLAG_CLUSTER, q);
> + q->limits.no_cluster = 1;
> + }
>
> /*
> * set a reasonable default alignment on word boundaries: the
>
> --
> dm-devel mailing list
> dm-devel@redhat.com
> https://www.redhat.com/mailman/listinfo/dm-devel
next prev parent reply other threads:[~2010-08-29 20:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-29 17:59 [PATCH] imported patch sync-no_cluster-with-cluster-flag.patch Malahal Naineni
2010-08-29 20:31 ` Malahal Naineni [this message]
2010-11-02 20:21 ` block: QUEUE_FLAG_CLUSTER and no_cluster are NOT in sync Mike Snitzer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100829203149.GC24466@us.ibm.com \
--to=malahal@us.ibm.com \
--cc=dm-devel@redhat.com \
--cc=jaxboe@fusionio.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.