All of lore.kernel.org
 help / color / mirror / Atom feed
From: Martin Pitt <martin.pitt@ubuntu.com>
To: linux-hotplug@vger.kernel.org
Subject: Re: udev-161-1 breaks DVD-ROM
Date: Mon, 30 Aug 2010 13:39:29 +0000	[thread overview]
Message-ID: <20100830133929.GA2524@piware.de> (raw)
In-Reply-To: <op.vh48hu1jee43hi@localhost.localdomain>

[-- Attachment #1: Type: text/plain, Size: 1270 bytes --]

Hello again,

Борис Васильев [2010-08-28 14:23 +0400]:
> udev version udev-161-1 breaks DVD-ROM functionality on my computer.
> After upgrade, putting in a DVD with data shows up as a blank DVD in GNOME.

So, I looked at the two logs attached on the arch bug report.
Unfortunately the 161-1 log file was done without a medium in the
drive (or you did it too early and the drive didn't finish reading the
disk yet). Can you please re-do the 161-1 log?

But while I looked through the code, I noticed a flaw in the "DVD-RW
ro/seq" patch [1]: It inserts the ro/seq differentiation into
feature_profiles(), but this should just detect the drive
capabilities, not the medium state.  I fixed that in [2], but I
suppose this is not the complete fix for that bug yet, since it didn't
break DVD-ROM operations at all, it just falsely claimed that they
were rewritable.

Thanks,

Martin

[1] http://git.kernel.org/?p=linux/hotplug/udev.git;a=commitdiff;h=cf2205a1986222fdc0238190f5742f54d943cd23
[2] http://git.kernel.org/?p=linux/hotplug/udev.git;a=commitdiff;h=2458db3edd8d66827b34978ff471dff8f879e9ab 
-- 
Martin Pitt                        | http://www.piware.de
Ubuntu Developer (www.ubuntu.com)  | Debian Developer  (www.debian.org)

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

  parent reply	other threads:[~2010-08-30 13:39 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-28 10:23 udev-161-1 breaks DVD-ROM Борис Васильев
2010-08-30  8:14 ` Martin Pitt
2010-08-30  8:35 ` Martin Pitt
2010-08-30 13:39 ` Martin Pitt [this message]
2010-08-30 22:45 ` Martin Pitt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100830133929.GA2524@piware.de \
    --to=martin.pitt@ubuntu.com \
    --cc=linux-hotplug@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.