From: AlexanderS <alexander@sulfrian.net>
To: kusmabite@gmail.com
Cc: gitster@pobox.com, git@vger.kernel.org
Subject: Re: [PATCHv4 1/2] daemon: add helper function named_sock_setup
Date: Mon, 30 Aug 2010 14:46:31 +0200 [thread overview]
Message-ID: <20100830144631.23d1a164@laptop.localhost> (raw)
In-Reply-To: <AANLkTindaa-wDkOMW=BgtNJ+Wmi3xaBo1o_CF7NFH=Qm@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 713 bytes --]
On Mon, 30 Aug 2010 14:12:52 +0200
Erik Faye-Lund <kusmabite@gmail.com> wrote:
> Since serve() isn't a library function, wouldn't it reduce needless
> code churn to just make socklist a set of global variables (or just a
> global struct)? That way you don't have to pass it around, changing
> all those function prototypes.
I don't understand: Even if I make socklist a global structure or
something like that, I also have to change all this function prototypes
to remove at least the old unused parameters.
> I'm a bit intimidated by this change since I have a rather big
> patch-set on top of daemon.c, and I really don't want to resolve a lot
> of conflicts. But I guess that's my problem :P
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2010-08-30 12:46 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-23 16:54 added possibility to supply more than one --listen argument to git-daemon Alexander Sulfrian
2010-08-23 16:54 ` [PATCH] " Alexander Sulfrian
2010-08-23 19:56 ` Junio C Hamano
2010-08-29 15:07 ` daemon: allow more than one host addresses given via --listen Alexander Sulfrian
2010-08-29 15:13 ` Alexander Sulfrian
2010-08-29 15:13 ` [PATCHv3 1/2] daemon: add helper function named_sock_setup Alexander Sulfrian
2010-08-29 15:13 ` [PATCHv3 2/2] daemon: allow more than one host address given via --listen Alexander Sulfrian
2010-08-30 7:28 ` Junio C Hamano
2010-08-30 11:30 ` Alexander Sulfrian
2010-08-30 11:30 ` [PATCHv4 1/2] daemon: add helper function named_sock_setup Alexander Sulfrian
2010-08-30 12:12 ` Erik Faye-Lund
2010-08-30 12:46 ` AlexanderS [this message]
2010-08-30 12:58 ` Erik Faye-Lund
2010-08-30 11:30 ` [PATCHv4 2/2] daemon: allow more than one host address given via --listen Alexander Sulfrian
2010-08-29 15:07 ` [PATCHv2 1/2] daemon: add helper function named_sock_setup Alexander Sulfrian
2010-08-29 15:07 ` [PATCHv2 2/2] daemon: allow more than one host address given via --listen Alexander Sulfrian
2010-08-29 15:11 ` Erik Faye-Lund
2010-08-29 15:17 ` AlexanderS
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100830144631.23d1a164@laptop.localhost \
--to=alexander@sulfrian.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=kusmabite@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.