From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from fieldses.org ([174.143.236.118]:34547 "EHLO fieldses.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755398Ab0H3REf (ORCPT ); Mon, 30 Aug 2010 13:04:35 -0400 Date: Mon, 30 Aug 2010 13:04:12 -0400 From: "J. Bruce Fields" To: Steve Dickson Cc: Jeff Layton , linux-nfs@vger.kernel.org, chuck.lever@oracle.com Subject: Re: [PATCH] rpc.nfsd: mount up nfsdfs is it doesn't appear to be mounted yet Message-ID: <20100830170412.GC9316@fieldses.org> References: <1282995314-8317-1-git-send-email-jlayton@redhat.com> <4C7BD394.3030705@RedHat.com> <20100830121600.529669bd@tlielax.poochiereds.net> <4C7BE1FC.2020400@RedHat.com> Content-Type: text/plain; charset=us-ascii In-Reply-To: <4C7BE1FC.2020400@RedHat.com> Sender: linux-nfs-owner@vger.kernel.org List-ID: MIME-Version: 1.0 On Mon, Aug 30, 2010 at 12:53:16PM -0400, Steve Dickson wrote: > On 08/30/2010 12:16 PM, Jeff Layton wrote: > > How this as an alternate proposal? > > > > We attempt to mount up nfsdfs. If the "threads" file still isn't > > present after the attempt, we then log a warning and go with the > > nfsctl() interface? > Has anybody test this legacy interface lately?? Does anybody anybody > depend on the existence of this interface??? I would guess the answer > would be no to both questions... So I see this as an opportunity so > simplify the code... which is always a good thing... > > So I would have no problem saying from the next release of nfs-utils, > the legacy interface is no longer supported... especially if there are > issues with IPV6. In general I'd like backwards-compatibility to be a very high priority, in both directions. (Both continuing to support old nfs-utils in new kernels, and supporting old kernels with new nfs-utils.) Among other advantages, it makes it easier to troubleshoot user problems if we don't have to ask them to upgrade multiple packages at once to test a fix. On the other hand, the nfsctl interface is pretty old (when did the new stuff go in, exactly?). On the other other hand, Jeff's patch isn't really very complicated. (Though the amount of additional code we could delete might be large.) --b.