All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: Mike Frysinger <vapier.adi@gmail.com>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>, Greg KH <gregkh@suse.de>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/5] tty/hw: move hardware drivers to drivers/tty/hw
Date: Mon, 30 Aug 2010 17:25:01 +0200	[thread overview]
Message-ID: <201008301725.01424.arnd@arndb.de> (raw)
In-Reply-To: <AANLkTi=F3xYJ5_umQTT9N7RqQBL04162RVEka5A9YgYN@mail.gmail.com>

On Monday 30 August 2010, Mike Frysinger wrote:
> 
> On Mon, Aug 30, 2010 at 08:28, Arnd Bergmann wrote:
> > On Monday 30 August 2010, Alan Cox wrote:
> >> > My impression was that it should actually be converted into an hvc
> >> > driver as a cleanup and moved to drivers/tty/hvc. It can probably
> >> > get reduced to one third of its size if you do that.
> >>
> >> Not sure it makes sense - hvc seems the wrong abstraction.
> >
> > It seems to be very similar to hvc_tile.c in purpose, which is
> > the most trivial driver we have. Why would that not work?
> >
> > Most of bfin_jtag_comm is about interfacing with the tty layer
> > and providing a kernel thread to do the polling, which is exactly
> > what hvc_console.c does.
> 
> i have no idea what "hvc" is, but my limited knowledge was that it was
> for large powerpc servers, so i didnt bother looking at it too much.
> i simply wanted a way to create a tty on top of the hardware channel.
> if there is a framework that doesnt break this usage and lets me
> simplify my driver, then either works for me.

HVC started out as the console for large powerpc, but has turned into
a generic framework for TTY drivers that are based on simple read/write
operations with or without interrupts. 

Please take a look at drivers/char/hvc_tile.c, which was added recently
for a scenario quite similar to yours (debug port, not irq).

	Arnd

  reply	other threads:[~2010-08-30 15:25 UTC|newest]

Thread overview: 55+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-29 21:06 [RFC 0/5] tty: move stuff around Arnd Bergmann
2010-08-29 21:06 ` [PATCH 1/5] tty: move tty layer code to drivers/tty Arnd Bergmann
2010-08-29 21:06 ` [PATCH 2/5] tty/vt: move files to drivers/tty/vt/ Arnd Bergmann
2010-08-29 21:06 ` [PATCH 3/5] tty/hvc: move files to drivers/tty/hvc Arnd Bergmann
2010-08-29 21:06 ` [PATCH 4/5] tty/hw: move hardware drivers to drivers/tty/hw Arnd Bergmann
2010-08-29 21:51   ` Mike Frysinger
2010-08-30  8:55     ` Arnd Bergmann
2010-08-30 10:54       ` Alan Cox
2010-08-30 12:28         ` Arnd Bergmann
2010-08-30 14:56           ` Mike Frysinger
2010-08-30 15:25             ` Arnd Bergmann [this message]
2010-08-30 15:26               ` Mike Frysinger
2010-08-29 21:06 ` [PATCH 5/5] tty: rearrange Kconfig structure Arnd Bergmann
2010-08-29 23:18 ` [RFC 0/5] tty: move stuff around Alan Cox
2010-08-30 11:37   ` Arnd Bergmann
2010-08-30 11:55     ` Jiri Slaby
2010-08-30 12:15       ` Arnd Bergmann
2010-08-30 13:00         ` Alan Cox
2010-08-30 21:04           ` Arnd Bergmann
2010-08-30 18:47 ` Greg KH
2010-08-30 21:33   ` Arnd Bergmann
2010-08-30 21:38     ` Jiri Slaby
2010-08-30 22:28     ` Alan Cox
2010-08-31  6:08       ` Jiri Slaby
2010-08-31  9:33         ` Alan Cox
2010-08-31  9:19           ` Jiri Slaby
2010-08-31  9:19             ` [PATCH 1/1] MAINTAINERS: remove isicom Jiri Slaby
2010-08-31 15:03               ` Joe Perches
2010-08-31 15:08                 ` [PATCH 1/1] MAINTAINERS: orphan isicom Jiri Slaby
2010-08-31  9:26       ` [RFC 0/5] tty: move stuff around Arnd Bergmann
2010-08-31 10:42         ` Rogier Wolff
2010-08-31 11:23           ` Alan Cox
2010-08-31 11:54           ` Arnd Bergmann
2010-08-31 13:32             ` Greg KH
2010-09-02 15:16           ` Michael H. Warfield
2010-09-03 12:13             ` Arnd Bergmann
2010-09-03 12:58               ` Gene Heskett
2010-09-03 13:34                 ` Arnd Bergmann
2010-08-31 15:53         ` Mike Frysinger
2010-09-02 20:12         ` Geert Uytterhoeven
2010-09-03 12:01           ` Arnd Bergmann
2010-08-31  4:11     ` Greg KH
2010-09-03 15:29     ` Arnd Bergmann
2010-09-03 16:55       ` Greg KH
2010-09-03 17:42         ` Arnd Bergmann
2010-09-03 22:46           ` Greg KH
2010-09-03 20:08       ` Geert Uytterhoeven
2010-09-03 20:32         ` Alan Cox
2010-09-03 20:23           ` Geert Uytterhoeven
2010-09-21 23:07       ` Greg KH
2010-09-21 23:08         ` [PATCH 1/2] TTY: create /tty and move the tty core files there Greg KH
2010-09-21 23:08           ` [PATCH 2/2] TTY: create tty/vt and move the vt code there Greg KH
2010-09-22  9:10             ` Arnd Bergmann
2010-09-22  9:13           ` [PATCH 1/2] TTY: create /tty and move the tty core files there Arnd Bergmann
2011-02-23  1:12       ` [RFC 0/5] tty: move stuff around Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201008301725.01424.arnd@arndb.de \
    --to=arnd@arndb.de \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=vapier.adi@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.