From: Anatolij Gustschin <agust@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] video: cfb_console: fix definition and usage of CURSOR_xxx macros
Date: Tue, 31 Aug 2010 01:02:46 +0200 [thread overview]
Message-ID: <20100831010246.42b41258@wker> (raw)
In-Reply-To: <1282941947-25692-1-git-send-email-timur@freescale.com>
On Fri, 27 Aug 2010 15:45:47 -0500
Timur Tabi <timur@freescale.com> wrote:
> The CURSOR_ON, CURSOR_OFF, and CURSOR_SET macros are defined incorrectly. If
> cursor support is disabled, then these macros are defined to nothing, but
> then they are used like this:
>
> if (console_col < CONSOLE_COLS)
> CURSOR_OFF
> console_row++;
>
> which was compiled like this:
>
> if (console_col < CONSOLE_COLS)
> console_row++;
>
> This is obviously not what was intended.
>
> Signed-off-by: Timur Tabi <timur@freescale.com>
> ---
>
> This patch depends on
>
> video: cfb_console: add support for 4bpp bitmaps with GDF_32BIT_X888RGB
>
> drivers/video/cfb_console.c | 24 ++++++++++++++----------
> 1 files changed, 14 insertions(+), 10 deletions(-)
Applied to u-boot-video/master. Thanks!
Best regards,
Anatolij
prev parent reply other threads:[~2010-08-30 23:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-27 20:45 [U-Boot] [PATCH] video: cfb_console: fix definition and usage of CURSOR_xxx macros Timur Tabi
2010-08-30 8:48 ` Detlev Zundel
2010-08-30 23:02 ` Anatolij Gustschin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100831010246.42b41258@wker \
--to=agust@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.