From mboxrd@z Thu Jan 1 00:00:00 1970 From: Robert Richter Subject: Re: [PATCH V2 0/4] Generalise ARM perf-events backend for oprofile Date: Tue, 31 Aug 2010 13:05:17 +0200 Message-ID: <20100831110517.GE22783@erda.amd.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Return-path: Received: from tx2ehsobe005.messaging.microsoft.com ([65.55.88.15]:32646 "EHLO TX2EHSOBE010.bigfish.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756973Ab0HaLYQ (ORCPT ); Tue, 31 Aug 2010 07:24:16 -0400 Content-Disposition: inline In-Reply-To: Sender: linux-arch-owner@vger.kernel.org List-ID: To: Matt Fleming Cc: "linux-kernel@vger.kernel.org" , Will Deacon , Paul Mundt , Russell King , "linux-arm-kernel@lists.infradead.org" , "linux-sh@vger.kernel.org" , Peter Zijlstra , Ingo Molnar , Frederic Weisbecker , Arnaldo Carvalho de Melo , "linux-arch@vger.kernel.org" On 26.08.10 15:09:15, Matt Fleming wrote: > The perf-events backend for OProfile that Will Deacon wrote in > 8c1fc96f6fd1f361428ba805103af0d0eee65179 ("ARM: 6072/1: oprofile: use > perf-events framework as backend") is of use to more architectures > than just ARM. Move the code into drivers/oprofile/ so that SH can use > it instead of the nearly identical copy of its OProfile code. > > The benefit of the backend is that it becomes necessary to only > maintain one copy of the PMU accessor functions for each architecture, > with bug fixes and new features benefiting both OProfile and perf. > > Note that I haven't been able to test these patches on an ARM board to > see if I've caused any regressions. If anyone else could do that I'd > appreciate it. Though, I have been able to compile this version of the > series. > > This patch series is based on tip/master. Matt, please rebase your next version of this patch set to git://git.kernel.org/pub/scm/linux/kernel/git/rric/oprofile.git core It contains Will's patches. Thanks, -Robert > > Changes from v1: > - Prefix the new functons with "oprofile_" instead of "op_". > - Fix ARM compilation errors > - Move all the oprofile-perf logic into oprofile_perf.c > - Include cleanup patch from Will > > Matt Fleming (3): > sh: Accessor functions for the sh_pmu state > oprofile: Abstract the perf-events backend > sh: Use the perf-events backend for oprofile > > Will Deacon (1): > oprofile: Handle initialisation failure more gracefully > > arch/arm/oprofile/Makefile | 4 + > arch/arm/oprofile/common.c | 228 ++++---------------------------------- > arch/sh/include/asm/perf_event.h | 2 + > arch/sh/kernel/perf_event.c | 13 ++ > arch/sh/oprofile/Makefile | 2 +- > arch/sh/oprofile/common.c | 96 +++------------- > arch/sh/oprofile/op_impl.h | 33 ------ > drivers/oprofile/oprofile_perf.c | 209 ++++++++++++++++++++++++++++++++++ > include/linux/oprofile.h | 12 ++ > 9 files changed, 283 insertions(+), 316 deletions(-) > delete mode 100644 arch/sh/oprofile/op_impl.h > create mode 100644 drivers/oprofile/oprofile_perf.c > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ > -- Advanced Micro Devices, Inc. Operating System Research Center From mboxrd@z Thu Jan 1 00:00:00 1970 From: Robert Richter Date: Tue, 31 Aug 2010 11:05:17 +0000 Subject: Re: [PATCH V2 0/4] Generalise ARM perf-events backend for oprofile Message-Id: <20100831110517.GE22783@erda.amd.com> List-Id: References: In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Matt Fleming Cc: "linux-kernel@vger.kernel.org" , Will Deacon , Paul Mundt , Russell King , "linux-arm-kernel@lists.infradead.org" , "linux-sh@vger.kernel.org" , Peter Zijlstra , Ingo Molnar , Frederic Weisbecker , Arnaldo Carvalho de Melo , "linux-arch@vger.kernel.org" On 26.08.10 15:09:15, Matt Fleming wrote: > The perf-events backend for OProfile that Will Deacon wrote in > 8c1fc96f6fd1f361428ba805103af0d0eee65179 ("ARM: 6072/1: oprofile: use > perf-events framework as backend") is of use to more architectures > than just ARM. Move the code into drivers/oprofile/ so that SH can use > it instead of the nearly identical copy of its OProfile code. > > The benefit of the backend is that it becomes necessary to only > maintain one copy of the PMU accessor functions for each architecture, > with bug fixes and new features benefiting both OProfile and perf. > > Note that I haven't been able to test these patches on an ARM board to > see if I've caused any regressions. If anyone else could do that I'd > appreciate it. Though, I have been able to compile this version of the > series. > > This patch series is based on tip/master. Matt, please rebase your next version of this patch set to git://git.kernel.org/pub/scm/linux/kernel/git/rric/oprofile.git core It contains Will's patches. Thanks, -Robert > > Changes from v1: > - Prefix the new functons with "oprofile_" instead of "op_". > - Fix ARM compilation errors > - Move all the oprofile-perf logic into oprofile_perf.c > - Include cleanup patch from Will > > Matt Fleming (3): > sh: Accessor functions for the sh_pmu state > oprofile: Abstract the perf-events backend > sh: Use the perf-events backend for oprofile > > Will Deacon (1): > oprofile: Handle initialisation failure more gracefully > > arch/arm/oprofile/Makefile | 4 + > arch/arm/oprofile/common.c | 228 ++++---------------------------------- > arch/sh/include/asm/perf_event.h | 2 + > arch/sh/kernel/perf_event.c | 13 ++ > arch/sh/oprofile/Makefile | 2 +- > arch/sh/oprofile/common.c | 96 +++------------- > arch/sh/oprofile/op_impl.h | 33 ------ > drivers/oprofile/oprofile_perf.c | 209 ++++++++++++++++++++++++++++++++++ > include/linux/oprofile.h | 12 ++ > 9 files changed, 283 insertions(+), 316 deletions(-) > delete mode 100644 arch/sh/oprofile/op_impl.h > create mode 100644 drivers/oprofile/oprofile_perf.c > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ > -- Advanced Micro Devices, Inc. Operating System Research Center From mboxrd@z Thu Jan 1 00:00:00 1970 From: robert.richter@amd.com (Robert Richter) Date: Tue, 31 Aug 2010 13:05:17 +0200 Subject: [PATCH V2 0/4] Generalise ARM perf-events backend for oprofile In-Reply-To: References: Message-ID: <20100831110517.GE22783@erda.amd.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 26.08.10 15:09:15, Matt Fleming wrote: > The perf-events backend for OProfile that Will Deacon wrote in > 8c1fc96f6fd1f361428ba805103af0d0eee65179 ("ARM: 6072/1: oprofile: use > perf-events framework as backend") is of use to more architectures > than just ARM. Move the code into drivers/oprofile/ so that SH can use > it instead of the nearly identical copy of its OProfile code. > > The benefit of the backend is that it becomes necessary to only > maintain one copy of the PMU accessor functions for each architecture, > with bug fixes and new features benefiting both OProfile and perf. > > Note that I haven't been able to test these patches on an ARM board to > see if I've caused any regressions. If anyone else could do that I'd > appreciate it. Though, I have been able to compile this version of the > series. > > This patch series is based on tip/master. Matt, please rebase your next version of this patch set to git://git.kernel.org/pub/scm/linux/kernel/git/rric/oprofile.git core It contains Will's patches. Thanks, -Robert > > Changes from v1: > - Prefix the new functons with "oprofile_" instead of "op_". > - Fix ARM compilation errors > - Move all the oprofile-perf logic into oprofile_perf.c > - Include cleanup patch from Will > > Matt Fleming (3): > sh: Accessor functions for the sh_pmu state > oprofile: Abstract the perf-events backend > sh: Use the perf-events backend for oprofile > > Will Deacon (1): > oprofile: Handle initialisation failure more gracefully > > arch/arm/oprofile/Makefile | 4 + > arch/arm/oprofile/common.c | 228 ++++---------------------------------- > arch/sh/include/asm/perf_event.h | 2 + > arch/sh/kernel/perf_event.c | 13 ++ > arch/sh/oprofile/Makefile | 2 +- > arch/sh/oprofile/common.c | 96 +++------------- > arch/sh/oprofile/op_impl.h | 33 ------ > drivers/oprofile/oprofile_perf.c | 209 ++++++++++++++++++++++++++++++++++ > include/linux/oprofile.h | 12 ++ > 9 files changed, 283 insertions(+), 316 deletions(-) > delete mode 100644 arch/sh/oprofile/op_impl.h > create mode 100644 drivers/oprofile/oprofile_perf.c > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo at vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ > -- Advanced Micro Devices, Inc. Operating System Research Center