From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Egger Subject: Re: [PATCH] re-enable HVM PCI passthrough functionality Date: Tue, 31 Aug 2010 11:35:28 +0200 Message-ID: <201008311135.29268.Christoph.Egger@amd.com> References: <987664A83D2D224EAE907B061CE93D53015D9B1A3E@orsmsx505.amr.corp.intel.com> <987664A83D2D224EAE907B061CE93D53015D9B1AE3@orsmsx505.amr.corp.intel.com> <20100831091727.GA23648@whitby.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20100831091727.GA23648@whitby.uk.xensource.com> Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Tim Deegan Cc: "xen-devel@lists.xensource.com" , "Kay, Allen M" , Keir Fraser List-Id: xen-devel@lists.xenproject.org On Tuesday 31 August 2010 11:17:27 Tim Deegan wrote: > At 02:58 +0100 on 31 Aug (1283223494), Kay, Allen M wrote: > > Attached patch reverts back to INVALID_MFN. PCI passthrough > > functionality works with this patch. > > Apologies for missing this - I did ask for this enormous patch to > contain only what it said on the tin (and I did read it to check!) but > this one got through. Also apologies from my side. I did what Tim requested for, but that one slipped through. > > Signed-off-by: Allen Kay allen.m.kay@intel.com > > This is fine, but please add a comment explaining the rather subtle use > of INVALID_MFN here so the next tidy-minded person doesn't "fix" it > again. :) > > In fact would it be better to check the returned type == p2m_mmio_direct > instead? That seems like it would fit better with the intention. Or > do other callers use this to clean non-mmio entries too? I'm interested in if this patch fixes the SR-IOV issue. We are still about investigation... Christoph -- ---to satisfy European Law for business letters: Advanced Micro Devices GmbH Einsteinring 24, 85609 Dornach b. Muenchen Geschaeftsfuehrer: Alberto Bozzo, Andrew Bowd Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen Registergericht Muenchen, HRB Nr. 43632