All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jarkko Nikula <jhnikula@gmail.com>
To: Peter Ujfalusi <peter.ujfalusi@nokia.com>
Cc: linux-omap@vger.kernel.org, tony@atomide.com
Subject: Re: [PATCH] OMAP: McBSP: Do not enable SRG in slave mode
Date: Tue, 31 Aug 2010 13:36:14 +0300	[thread overview]
Message-ID: <20100831133614.a7d0c031.jhnikula@gmail.com> (raw)
In-Reply-To: <1283242304-27738-1-git-send-email-peter.ujfalusi@nokia.com>

On Tue, 31 Aug 2010 11:11:44 +0300
Peter Ujfalusi <peter.ujfalusi@nokia.com> wrote:

> McBSP SRG (Sample Rate Generator) and FSG (Frame Sync
> Generator) is only needed to be enabled, when McBSP
> is master.
> In McBSP slave mode, the SRG, and FSG can be kept disabled,
> which might save some power at the end in this configuration.
> 
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@nokia.com>
> ---
> 
> Hello Jarkko,
> 
> I have tested this on OMAP3, but I think this should be
> applicable for other OMAP versions as well.
> When McBSP was slave the audio worked fine, when I left
> the SRG, and FSG disabled.
> 
Sounds logical if there is no need to keep SRG and FSG active when
McBSP is slave. I tested this on N810.

Acked-by: Jarkko Nikula <jhnikula@gmail.com>

  reply	other threads:[~2010-08-31 10:35 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-31  8:11 [PATCH] OMAP: McBSP: Do not enable SRG in slave mode Peter Ujfalusi
2010-08-31 10:36 ` Jarkko Nikula [this message]
2010-09-23 18:08 ` [APPLIED] " Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100831133614.a7d0c031.jhnikula@gmail.com \
    --to=jhnikula@gmail.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=peter.ujfalusi@nokia.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.