From: Feng Tang <feng.tang@intel.com>
To: Yong Wang <yong.y.wang@linux.intel.com>
Cc: David Brownell <dbrownell@users.sourceforge.net>,
Grant Likely <grant.likely@secretlab.ca>,
"spi-devel-general@lists.sourceforge.net"
<spi-devel-general@lists.sourceforge.net>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
<alan@linux.intel.com>
Subject: Re: [PATCH] spi/dw_spi: Enable Intel Moorestown SPI controller 1
Date: Tue, 31 Aug 2010 15:39:36 +0800 [thread overview]
Message-ID: <20100831153936.2ca0475c@feng-i7> (raw)
In-Reply-To: <20100831061416.GA5904@ywang-moblin2.bj.intel.com>
NAK.
We should not export SPI1 has x86 core has no way to access its register.
though the device physically exists.
Thanks,
Feng
On Tue, 31 Aug 2010 14:14:16 +0800
Yong Wang <yong.y.wang@linux.intel.com> wrote:
> Enable Intel Moorestown SPI controller 1
>
> Signed-off-by: Yong Wang <yong.y.wang@intel.com>
> ---
> drivers/spi/dw_spi_pci.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/spi/dw_spi_pci.c b/drivers/spi/dw_spi_pci.c
> index 1f52755..eec9d0b 100644
> --- a/drivers/spi/dw_spi_pci.c
> +++ b/drivers/spi/dw_spi_pci.c
> @@ -142,6 +142,8 @@ static int spi_resume(struct pci_dev *pdev)
> static const struct pci_device_id pci_ids[] __devinitdata = {
> /* Intel Moorestown platform SPI controller 0 */
> { PCI_DEVICE(PCI_VENDOR_ID_INTEL, 0x0800) },
> + /* Intel Moorestown platform SPI controller 1 */
> + { PCI_DEVICE(PCI_VENDOR_ID_INTEL, 0x0801) },
> {},
> };
>
prev parent reply other threads:[~2010-08-31 7:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-31 6:14 [PATCH] spi/dw_spi: Enable Intel Moorestown SPI controller 1 Yong Wang
2010-08-31 7:39 ` Feng Tang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100831153936.2ca0475c@feng-i7 \
--to=feng.tang@intel.com \
--cc=alan@linux.intel.com \
--cc=dbrownell@users.sourceforge.net \
--cc=grant.likely@secretlab.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=spi-devel-general@lists.sourceforge.net \
--cc=yong.y.wang@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.