diff for duplicates of <20100831161644.GA14505@albatros> diff --git a/a/1.txt b/N1/1.txt index 0c5e7ae..8e0f9be 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -10,11 +10,11 @@ On Tue, Aug 31, 2010 at 18:08 +0200, Julia Lawall wrote: > > > --- a/drivers/macintosh/via-pmu-led.c > > > +++ b/drivers/macintosh/via-pmu-led.c > > > @@ -92,8 +92,10 @@ static int __init via_pmu_led_init(void) -> > > if (dt = NULL) +> > > if (dt == NULL) > > > return -ENODEV; > > > model = of_get_property(dt, "model", NULL); -> > > - if (model = NULL) -> > > + if (model = NULL) { +> > > - if (model == NULL) +> > > + if (model == NULL) { > > > + of_node_put(dt); > > > return -ENODEV; > > > + } diff --git a/a/content_digest b/N1/content_digest index eccd247..b551ae0 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -2,16 +2,15 @@ "ref\01283075566-27441-2-git-send-email-julia@diku.dk\0" "ref\04C7D247F.4060500@bfs.de\0" "ref\0Pine.LNX.4.64.1008311807470.2668@ask.diku.dk\0" - "ref\0Pine.LNX.4.64.1008311807470.2668-QfmoRoYWmW9knbxzx/v8hQ@public.gmane.org\0" "From\0Vasiliy Kulikov <segooon@gmail.com>\0" - "Subject\0Re: [PATCH 1/7] drivers/macintosh/via-pmu-led.c: Add of_node_put\0" - "Date\0Tue, 31 Aug 2010 16:16:44 +0000\0" - "To\0Julia Lawall <julia-dAYI7NvHqcQ@public.gmane.org>\0" - "Cc\0devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org" - kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org - linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org - linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org - " walter harms <wharms-fPG8STNUNVg@public.gmane.org>\0" + "Subject\0Re: [PATCH 1/7] drivers/macintosh/via-pmu-led.c: Add of_node_put to avoid memory leak\0" + "Date\0Tue, 31 Aug 2010 20:16:44 +0400\0" + "To\0Julia Lawall <julia@diku.dk>\0" + "Cc\0devicetree-discuss@lists.ozlabs.org" + kernel-janitors@vger.kernel.org + linux-kernel@vger.kernel.org + linuxppc-dev@lists.ozlabs.org + " walter harms <wharms@bfs.de>\0" "\00:1\0" "b\0" "On Tue, Aug 31, 2010 at 18:08 +0200, Julia Lawall wrote:\n" @@ -26,11 +25,11 @@ "> > > --- a/drivers/macintosh/via-pmu-led.c\n" "> > > +++ b/drivers/macintosh/via-pmu-led.c\n" "> > > @@ -92,8 +92,10 @@ static int __init via_pmu_led_init(void)\n" - "> > > \tif (dt = NULL)\n" + "> > > \tif (dt == NULL)\n" "> > > \t\treturn -ENODEV;\n" "> > > \tmodel = of_get_property(dt, \"model\", NULL);\n" - "> > > -\tif (model = NULL)\n" - "> > > +\tif (model = NULL) {\n" + "> > > -\tif (model == NULL)\n" + "> > > +\tif (model == NULL) {\n" "> > > +\t\tof_node_put(dt);\n" "> > > \t\treturn -ENODEV;\n" "> > > +\t}\n" @@ -55,4 +54,4 @@ "-- \n" Vasiliy -3937b47ba19c6b99fda88987cd2fbae92028dd9000adf49152b1a7a2ed4bd760 +75c0133a414fe42ec853351685939b469347daa669428807b687963819396bc9
diff --git a/a/1.txt b/N2/1.txt index 0c5e7ae..8e0f9be 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -10,11 +10,11 @@ On Tue, Aug 31, 2010 at 18:08 +0200, Julia Lawall wrote: > > > --- a/drivers/macintosh/via-pmu-led.c > > > +++ b/drivers/macintosh/via-pmu-led.c > > > @@ -92,8 +92,10 @@ static int __init via_pmu_led_init(void) -> > > if (dt = NULL) +> > > if (dt == NULL) > > > return -ENODEV; > > > model = of_get_property(dt, "model", NULL); -> > > - if (model = NULL) -> > > + if (model = NULL) { +> > > - if (model == NULL) +> > > + if (model == NULL) { > > > + of_node_put(dt); > > > return -ENODEV; > > > + } diff --git a/a/content_digest b/N2/content_digest index eccd247..9d5d0aa 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -2,16 +2,17 @@ "ref\01283075566-27441-2-git-send-email-julia@diku.dk\0" "ref\04C7D247F.4060500@bfs.de\0" "ref\0Pine.LNX.4.64.1008311807470.2668@ask.diku.dk\0" - "ref\0Pine.LNX.4.64.1008311807470.2668-QfmoRoYWmW9knbxzx/v8hQ@public.gmane.org\0" "From\0Vasiliy Kulikov <segooon@gmail.com>\0" - "Subject\0Re: [PATCH 1/7] drivers/macintosh/via-pmu-led.c: Add of_node_put\0" - "Date\0Tue, 31 Aug 2010 16:16:44 +0000\0" - "To\0Julia Lawall <julia-dAYI7NvHqcQ@public.gmane.org>\0" - "Cc\0devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org" - kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org - linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org - linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org - " walter harms <wharms-fPG8STNUNVg@public.gmane.org>\0" + "Subject\0Re: [PATCH 1/7] drivers/macintosh/via-pmu-led.c: Add of_node_put to avoid memory leak\0" + "Date\0Tue, 31 Aug 2010 20:16:44 +0400\0" + "To\0Julia Lawall <julia@diku.dk>\0" + "Cc\0walter harms <wharms@bfs.de>" + Benjamin Herrenschmidt <benh@kernel.crashing.org> + kernel-janitors@vger.kernel.org + Grant Likely <grant.likely@secretlab.ca> + linuxppc-dev@lists.ozlabs.org + linux-kernel@vger.kernel.org + " devicetree-discuss@lists.ozlabs.org\0" "\00:1\0" "b\0" "On Tue, Aug 31, 2010 at 18:08 +0200, Julia Lawall wrote:\n" @@ -26,11 +27,11 @@ "> > > --- a/drivers/macintosh/via-pmu-led.c\n" "> > > +++ b/drivers/macintosh/via-pmu-led.c\n" "> > > @@ -92,8 +92,10 @@ static int __init via_pmu_led_init(void)\n" - "> > > \tif (dt = NULL)\n" + "> > > \tif (dt == NULL)\n" "> > > \t\treturn -ENODEV;\n" "> > > \tmodel = of_get_property(dt, \"model\", NULL);\n" - "> > > -\tif (model = NULL)\n" - "> > > +\tif (model = NULL) {\n" + "> > > -\tif (model == NULL)\n" + "> > > +\tif (model == NULL) {\n" "> > > +\t\tof_node_put(dt);\n" "> > > \t\treturn -ENODEV;\n" "> > > +\t}\n" @@ -55,4 +56,4 @@ "-- \n" Vasiliy -3937b47ba19c6b99fda88987cd2fbae92028dd9000adf49152b1a7a2ed4bd760 +d6f44153e0905904c5ccaf271163394f93db7ca612eb24257c1095bba93ca6a7
diff --git a/a/1.txt b/N3/1.txt index 0c5e7ae..8e0f9be 100644 --- a/a/1.txt +++ b/N3/1.txt @@ -10,11 +10,11 @@ On Tue, Aug 31, 2010 at 18:08 +0200, Julia Lawall wrote: > > > --- a/drivers/macintosh/via-pmu-led.c > > > +++ b/drivers/macintosh/via-pmu-led.c > > > @@ -92,8 +92,10 @@ static int __init via_pmu_led_init(void) -> > > if (dt = NULL) +> > > if (dt == NULL) > > > return -ENODEV; > > > model = of_get_property(dt, "model", NULL); -> > > - if (model = NULL) -> > > + if (model = NULL) { +> > > - if (model == NULL) +> > > + if (model == NULL) { > > > + of_node_put(dt); > > > return -ENODEV; > > > + } diff --git a/a/content_digest b/N3/content_digest index eccd247..6915b13 100644 --- a/a/content_digest +++ b/N3/content_digest @@ -3,9 +3,9 @@ "ref\04C7D247F.4060500@bfs.de\0" "ref\0Pine.LNX.4.64.1008311807470.2668@ask.diku.dk\0" "ref\0Pine.LNX.4.64.1008311807470.2668-QfmoRoYWmW9knbxzx/v8hQ@public.gmane.org\0" - "From\0Vasiliy Kulikov <segooon@gmail.com>\0" - "Subject\0Re: [PATCH 1/7] drivers/macintosh/via-pmu-led.c: Add of_node_put\0" - "Date\0Tue, 31 Aug 2010 16:16:44 +0000\0" + "From\0Vasiliy Kulikov <segooon-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>\0" + "Subject\0Re: [PATCH 1/7] drivers/macintosh/via-pmu-led.c: Add of_node_put to avoid memory leak\0" + "Date\0Tue, 31 Aug 2010 20:16:44 +0400\0" "To\0Julia Lawall <julia-dAYI7NvHqcQ@public.gmane.org>\0" "Cc\0devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org" kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org @@ -26,11 +26,11 @@ "> > > --- a/drivers/macintosh/via-pmu-led.c\n" "> > > +++ b/drivers/macintosh/via-pmu-led.c\n" "> > > @@ -92,8 +92,10 @@ static int __init via_pmu_led_init(void)\n" - "> > > \tif (dt = NULL)\n" + "> > > \tif (dt == NULL)\n" "> > > \t\treturn -ENODEV;\n" "> > > \tmodel = of_get_property(dt, \"model\", NULL);\n" - "> > > -\tif (model = NULL)\n" - "> > > +\tif (model = NULL) {\n" + "> > > -\tif (model == NULL)\n" + "> > > +\tif (model == NULL) {\n" "> > > +\t\tof_node_put(dt);\n" "> > > \t\treturn -ENODEV;\n" "> > > +\t}\n" @@ -55,4 +55,4 @@ "-- \n" Vasiliy -3937b47ba19c6b99fda88987cd2fbae92028dd9000adf49152b1a7a2ed4bd760 +569f904101738b90cf57225dac53cec65f59f668bf7e257a5e21b585d8ba3c5e
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.