From: "John W. Linville" <linville@tuxdriver.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org, Miles Lane <miles.lane@gmail.com>,
rjw@sisk.pl, maciej.rutecki@gmail.com
Subject: Re: [PATCH 2.6.36] wireless: register wiphy rfkill w/o holding cfg80211_mutex
Date: Tue, 31 Aug 2010 13:55:47 -0400 [thread overview]
Message-ID: <20100831175546.GD2484@tuxdriver.com> (raw)
In-Reply-To: <1283237477.3733.0.camel@jlt3.sipsolutions.net>
On Tue, Aug 31, 2010 at 08:51:17AM +0200, Johannes Berg wrote:
> Thanks,
>
> > + res = rfkill_register(rdev->rfkill);
> > + if (res)
> > + return res;
> > +
> > mutex_lock(&cfg80211_mutex);
> >
> > res = device_add(&rdev->wiphy.dev);
> > if (res)
> > goto out_unlock;
>
> but does that behave correctly in sysfs? rfkill_register should create
> some sysfs stuff that points to the device that now only gets added
> later, doesn't that break things?
Yeah, I see that now -- should have looked closer.
John
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
next prev parent reply other threads:[~2010-08-31 17:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-30 22:10 [PATCH 2.6.36] wireless: register wiphy rfkill w/o holding cfg80211_mutex John W. Linville
2010-08-31 6:51 ` Johannes Berg
2010-08-31 17:55 ` John W. Linville [this message]
2010-08-31 17:57 ` [PATCH] " John W. Linville
2010-08-31 18:10 ` Johannes Berg
2010-08-31 23:08 ` Miles Lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100831175546.GD2484@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=maciej.rutecki@gmail.com \
--cc=miles.lane@gmail.com \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.