From: Stephen Hemminger <shemminger@vyatta.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: David Miller <davem@davemloft.net>, netdev <netdev@vger.kernel.org>
Subject: Re: [RFC PATCH net-next-2.6] gro: drivers should feed GRO only with TCP packets
Date: Wed, 1 Sep 2010 10:42:35 -0700 [thread overview]
Message-ID: <20100901104235.5476a242@nehalam> (raw)
In-Reply-To: <1283360686.2556.381.camel@edumazet-laptop>
On Wed, 01 Sep 2010 19:04:46 +0200
Eric Dumazet <eric.dumazet@gmail.com> wrote:
> Many network devices can tell if an incoming frame is a TCP one for a
> small cost.
>
> Instead of feeding GRO with all packets, we could filter packets on this
> information ?
>
> This should help machines handling a mixed UDP/TCP workload, keeping gro
> overhead as small as possible.
>
> patch against tg3 as an example...
>
> Alternative would be to set a bit "is_tcp" on napi_struct to let this
> choice being done in network stack, not by each driver.
>
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
There was talk of doing GRO for UDP as well bug it never
got implemented.
--
next prev parent reply other threads:[~2010-09-01 17:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-01 17:04 [RFC PATCH net-next-2.6] gro: drivers should feed GRO only with TCP packets Eric Dumazet
2010-09-01 17:42 ` Stephen Hemminger [this message]
2010-09-01 17:48 ` David Miller
2010-09-01 17:55 ` Stephen Hemminger
2010-09-01 20:10 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100901104235.5476a242@nehalam \
--to=shemminger@vyatta.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.