From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from wolverine02.qualcomm.com ([199.106.114.251]:48253 "EHLO wolverine02.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753731Ab0IAPFy (ORCPT ); Wed, 1 Sep 2010 11:05:54 -0400 Date: Wed, 1 Sep 2010 20:35:36 +0530 From: Pavan Kondeti Subject: Re: [PATCH 1/5] USB: Add MSM USB Device Controller driver Message-ID: <20100901150536.GA9807@codeaurora.org> References: <1283332010-7184-2-git-send-email-pkondeti@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-arm-msm-owner@vger.kernel.org List-ID: To: Alan Stern Cc: gregkh@suse.de, linux-usb@vger.kernel.org, linux-arm-msm@vger.kernel.org, lockwood@android.com, swetland@android.com, Brian Swetland On Wed, Sep 01, 2010 at 10:03:54AM -0400, Alan Stern wrote: > On Wed, 1 Sep 2010, Pavankumar Kondeti wrote: > > > This patch adds the basic support for the USB Device Controller on Qualcomm > > MSM family of SOCs. The controller supports upto 16 endpoints including the > > default endpoint (ep0). All the data transfers are driven by DMA. > > > > VBUS line is also connected to PMIC chip. The module controlling PMIC chip > > notifies about cable connect/disconnect events. Hence, PHY comparators > > are turned off in low power mode. > > > > This driver was originally developed by Google and is available at > > http://android.git.kernel.org/?p=kernel/experimental.git. > > ... > > > +static const struct usb_ep_ops msm72k_ep_ops = { > > + .enable = msm72k_enable, > > + .disable = msm72k_disable, > > + > > + .alloc_request = msm72k_alloc_request, > > + .free_request = msm72k_free_request, > > + > > + .queue = msm72k_queue, > > + .dequeue = msm72k_dequeue, > > + > > + .set_halt = msm72k_set_halt, > > + .fifo_flush = msm72k_fifo_flush, > > +}; > > The .set_wedge method is missing. Thanks for pointing this out. I will implement this method. -- Sent by a consultant of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.