From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Eric Millbrandt <emillbrandt@dekaresearch.com>
Cc: Liam Girdwood <lrg@slimlogic.co.uk>, linux-input@vger.kernel.org
Subject: Re: [RFC] Input: wm97xx-core - Remove save state from wm97xx_read_aux_adc()
Date: Wed, 1 Sep 2010 18:19:25 +0100 [thread overview]
Message-ID: <20100901171925.GA22444@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <1283352730-15509-1-git-send-email-emillbrandt@dekaresearch.com>
On Wed, Sep 01, 2010 at 10:52:10AM -0400, Eric Millbrandt wrote:
> Saving the state of the digitizers seems unnecessary since the next
> sample will rewrite those registers. It also causes an unnecessary
> sample to occur if the previous state was a sample. This will cause
> the wrong sample to be returned on the next call to wm97xx_read_aux_adc().
You need to explain how this interacts with both polling and continuous
touchscreen modes - saying that it seems unneeded feels a little fuzzy.
Note that this will also clear the current digitiser configuration
before it starts the AUXADC so it's not a simple save of the values.
next prev parent reply other threads:[~2010-09-01 17:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-01 14:52 [RFC] Input: wm97xx-core - Remove save state from wm97xx_read_aux_adc() Eric Millbrandt
2010-09-01 17:19 ` Mark Brown [this message]
2010-09-01 18:46 ` Eric Millbrandt
2010-09-01 18:46 ` Mark Brown
2010-09-01 19:17 ` Eric Millbrandt
2010-09-02 14:40 ` Mark Brown
2010-09-02 15:32 ` Eric Millbrandt
2010-09-02 16:16 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100901171925.GA22444@rakim.wolfsonmicro.main \
--to=broonie@opensource.wolfsonmicro.com \
--cc=emillbrandt@dekaresearch.com \
--cc=linux-input@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.