All of lore.kernel.org
 help / color / mirror / Atom feed
From: Neil Brown <neilb@suse.de>
To: Jeff Layton <jlayton@redhat.com>
Cc: "J. Bruce Fields" <bfields@fieldses.org>,
	steved@redhat.com, linux-nfs@vger.kernel.org
Subject: Re: [PATCH] rpc.nfsd: mount up nfsdfs is it doesn't appear to be mounted yet (try #2)
Date: Thu, 2 Sep 2010 07:31:56 +1000	[thread overview]
Message-ID: <20100902073156.577757b5@notabene> (raw)
In-Reply-To: <20100901165605.41f4978d@tlielax.poochiereds.net>


Hi,
 I was musing about this and thought I would share my musings - not to be
 taken too seriously unless they resonate with you.

 If rpc.nfsd is mounting /proc/fs/nfsd, should it also be starting rpc.statd,
 which should be running before nfsd is started?
 Should it 'exportfs -av' too?

 Should mount.nfs be mounting /var/lib/nfs/rpc_pipefs too?
 It already runs statd as requimred, which in-turn runs sm-notify, though it
 is really best to run that much earlier.

 How far do we really want to go with this "just do the right thing" approach?

 Should "rpc.nfsd" be a replacement for /etc/init.d/nfs-kernel-server or
 whatever your favourite distro calls it?  Or should it just be a tool for
 managing the nfsd threads?


 I could imagine that it would be OK to add a '-L' flag to say 'use legacy
 interface' and have rpc.nfsd fail noisily if nfsdfs wasn't mounted, and -L
 wasn't given.

 I could imagine that if protocol options were specified with -L, that would
 be an error.

 And if protocol options are specified which differ from what is currently
 in-force, and there are active threads, rpc.nfsd could:
    reduce the number of threads to 0
    change the protocol options
    restore the number of threads



 I think it is (long past) time to deprecate the legacy support in the kernel
 at least.  I suggest we add a printk to sys_nfsservctl to warn of pending
 deprecation, and probably add an entry to
 Documentation/feature-removal-schedule.txt.
 Aim for removing it all in 2.6.40 ?? and make it a CONFIG option before that.

 BTW, the 'new' cache has was added during 2.5 - definitely before Jan 2003.
 So the old stuff really is quite old now.

NeilBrown

  reply	other threads:[~2010-09-01 21:32 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-31 19:32 [PATCH] rpc.nfsd: mount up nfsdfs is it doesn't appear to be mounted yet (try #2) Jeff Layton
2010-09-01 20:48 ` J. Bruce Fields
2010-09-01 20:56   ` Jeff Layton
2010-09-01 21:31     ` Neil Brown [this message]
2010-09-02  0:17       ` Jeff Layton
2010-09-02  1:32       ` J. Bruce Fields
2010-09-02 11:29       ` Steve Dickson
2010-09-02 11:55         ` Jeff Layton
2010-09-02 14:04           ` Chuck Lever
2010-09-02 14:25             ` J. Bruce Fields
2010-09-02 16:41               ` Steve Dickson
2010-09-02 18:49                 ` J. Bruce Fields
2010-09-02 14:30       ` Chuck Lever
2010-09-14 13:23 ` Jeff Layton
2010-09-15 20:09   ` Steve Dickson
2010-09-15 22:31     ` Jeff Layton
2010-09-16 11:06       ` Steve Dickson
2010-09-16 11:32         ` Jeff Layton
     [not found]           ` <20100916073203.2c217bfc-xSBYVWDuneFaJnirhKH9O4GKTjYczspe@public.gmane.org>
2010-09-16 11:43             ` Steve Dickson
2010-09-16 12:30     ` Steve Dickson
2010-09-16 13:02 ` [PATCH] rpc.nfsd: mount up nfsdfs is it doesn't appear to be mounted yet (try #4) Steve Dickson
     [not found]   ` <4C921580.2050903-AfCzQyP5zfLQT0dZR+AlfA@public.gmane.org>
2010-09-16 13:40     ` Jeff Layton
2010-09-16 21:32     ` Steve Dickson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100902073156.577757b5@notabene \
    --to=neilb@suse.de \
    --cc=bfields@fieldses.org \
    --cc=jlayton@redhat.com \
    --cc=linux-nfs@vger.kernel.org \
    --cc=steved@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.