From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Egger Subject: Re: Re: [PATCH] re-enable HVM PCI passthrough functionality Date: Thu, 2 Sep 2010 10:34:18 +0200 Message-ID: <201009021034.18866.Christoph.Egger@amd.com> References: <987664A83D2D224EAE907B061CE93D53015D9B1A3E@orsmsx505.amr.corp.intel.com> <20100901085632.GB1432@whitby.uk.xensource.com> <749B9D3DBF0F054390025D9EAFF47F222A418823@shsmsx501.ccr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <749B9D3DBF0F054390025D9EAFF47F222A418823@shsmsx501.ccr.corp.intel.com> Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: "Zhang, Yang Z" Cc: "xen-devel@lists.xensource.com" , "Kay, Allen M" , Tim Deegan , Keir Fraser List-Id: xen-devel@lists.xenproject.org On Thursday 02 September 2010 04:26:32 Zhang, Yang Z wrote: > With allen's patch, both vt-d and sr-iov can work now. Thanks allen. We were not able to reproduce SR-IOV failures with and without the fix on AMD machines. I am wondering if there are differences in memory mappings between AMD and Intel PCI passthrough. Nonetheless, good to know this has been fixed. Thanks, Christoph > best regards > yang > > > -----Original Message----- > > From: xen-devel-bounces@lists.xensource.com > > [mailto:xen-devel-bounces@lists.xensource.com] On Behalf Of Tim Deegan > > Sent: Wednesday, September 01, 2010 4:57 PM > > To: Kay, Allen M > > Cc: Christoph Egger; xen-devel@lists.xensource.com; Keir Fraser > > Subject: [Xen-devel] Re: [PATCH] re-enable HVM PCI passthrough > > functionality > > > > At 17:13 +0100 on 31 Aug (1283274786), Kay, Allen M wrote: > > > I have updated the patch to indicate valid_mfn() cannot be used here > > > as MMIO pages are always above max_mem. Also added sanity checking > > > for type == p2m_mmio_direct before clearing page table entry. This > > > should fix both VT-d and SR-IOV issues reported recently as there are > > > no SR-IOV specific code in Xen. As far as Xen is concern, SR-IOV > > > virtual function is just another PCI device. > > > > Applied; thanks for the fix. > > > > Tim. > > > > > Signed-off-by: Allen Kay allen.m.kay@intel.com > > > > > > -----Original Message----- > > > From: Christoph Egger [mailto:Christoph.Egger@amd.com] > > > Sent: Tuesday, August 31, 2010 2:35 AM > > > To: Tim Deegan > > > Cc: Kay, Allen M; xen-devel@lists.xensource.com; Keir Fraser > > > Subject: Re: [PATCH] re-enable HVM PCI passthrough functionality > > > > > > On Tuesday 31 August 2010 11:17:27 Tim Deegan wrote: > > > > At 02:58 +0100 on 31 Aug (1283223494), Kay, Allen M wrote: > > > > > Attached patch reverts back to INVALID_MFN. PCI passthrough > > > > > functionality works with this patch. > > > > > > > > Apologies for missing this - I did ask for this enormous patch to > > > > contain only what it said on the tin (and I did read it to check!) > > > > but this one got through. > > > > > > Also apologies from my side. I did what Tim requested for, but that > > > one slipped through. > > > > > > > > Signed-off-by: Allen Kay allen.m.kay@intel.com > > > > > > > > This is fine, but please add a comment explaining the rather subtle > > > > use of INVALID_MFN here so the next tidy-minded person doesn't "fix" > > > > it again. :) > > > > > > > > In fact would it be better to check the returned type == > > > > p2m_mmio_direct instead? That seems like it would fit better with > > > > the intention. Or do other callers use this to clean non-mmio > > > > entries too? > > > > > > I'm interested in if this patch fixes the SR-IOV issue. We are still > > > about investigation... > > > > > > Christoph -- ---to satisfy European Law for business letters: Advanced Micro Devices GmbH Einsteinring 24, 85609 Dornach b. Muenchen Geschaeftsfuehrer: Alberto Bozzo, Andrew Bowd Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen Registergericht Muenchen, HRB Nr. 43632