From: Arnd Bergmann <arnd@arndb.de>
To: CAI Qian <caiqian@redhat.com>
Cc: Ken'ichi Ohmichi <oomichi@mxs.nes.nec.co.jp>,
akpm@linux-foundation.org, fweisbec@gmail.com,
kexec <kexec@lists.infradead.org>,
viro@zeniv.linux.org.uk, jkacur@redhat.com, tglx@linutronix.de,
mingo@elte.hu, kamezawa.hiroyu@jp.fujitsu.com
Subject: fix /proc/vmcore seek
Date: Thu, 2 Sep 2010 14:20:19 +0200 [thread overview]
Message-ID: <201009021420.19914.arnd@arndb.de> (raw)
In-Reply-To: <289862590.1906641283428317221.JavaMail.root@zmail06.collab.prod.int.phx2.redhat.com>
Commit 73296bc611 "procfs: Use generic_file_llseek in /proc/vmcore" broke
seeking on /proc/vmcore. This changes it back to use default_llseek
in order to restore the original behaviour.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: stable@kernel.org
---
On Thursday 02 September 2010, CAI Qian wrote:
>
> Ken'ichi, it turned out this kernel patch caused makedumpfile failure below.
> I am not sure if this is a kernel bug or makedumpfile needs to catch up with
> the change.
It doesn't matter who is correct here. A user program regressed because of a
kernel change, so we need to fix the kernel. Thanks for the report!
Please try this patch.
--- a/fs/proc/vmcore.c
+++ b/fs/proc/vmcore.c
@@ -163,7 +163,7 @@ static ssize_t read_vmcore(struct file *file, char __user *buffer,
static const struct file_operations proc_vmcore_operations = {
.read = read_vmcore,
- .llseek = generic_file_llseek,
+ .llseek = default_llseek,
};
static struct vmcore* __init get_new_element(void)
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
next prev parent reply other threads:[~2010-09-02 12:20 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <839326586.1621551283237394919.JavaMail.root@zmail06.collab.prod.int.phx2.redhat.com>
2010-08-31 6:50 ` makedumpfile failed for 2.6.36-rc2 caiqian
2010-08-31 7:28 ` Ken'ichi Ohmichi
2010-08-31 8:29 ` CAI Qian
2010-09-01 4:33 ` Ken'ichi Ohmichi
2010-09-01 5:16 ` CAI Qian
2010-09-02 11:51 ` CAI Qian
2010-09-02 12:20 ` Arnd Bergmann [this message]
2010-09-02 14:23 ` fix /proc/vmcore seek CAI Qian
2010-09-03 1:00 ` Ken'ichi Ohmichi
2010-09-03 11:45 ` Arnd Bergmann
2010-09-03 20:58 ` Andrew Morton
2010-09-03 21:10 ` Frederic Weisbecker
2010-09-06 1:10 ` [PATCH][mmotm] unsigned offset llseek support (Was " KAMEZAWA Hiroyuki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201009021420.19914.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=akpm@linux-foundation.org \
--cc=caiqian@redhat.com \
--cc=fweisbec@gmail.com \
--cc=jkacur@redhat.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=kexec@lists.infradead.org \
--cc=mingo@elte.hu \
--cc=oomichi@mxs.nes.nec.co.jp \
--cc=tglx@linutronix.de \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.