From: Jonathan Nieder <jrnieder@gmail.com>
To: Eric Wong <normalperson@yhbt.net>
Cc: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
git@vger.kernel.org, "Jakub Narebski" <jnareb@gmail.com>,
"Pavan Kumar Sunkara" <pavan.sss1991@gmail.com>
Subject: [PATCH/RFC maint-1.7.1 0/4] instaweb 1.7.1 fixes for Debian squeeze
Date: Thu, 2 Sep 2010 18:52:37 -0500 [thread overview]
Message-ID: <20100902235237.GA6466@burratino> (raw)
In-Reply-To: <20100902223624.GA9613@dcvr.yhbt.net>
Eric Wong wrote:
>> Uwe Kleine-König wrote:
>>> when I start git instaweb on a git repository, I get a crippled view
>>> (no style sheets, no images) that doesn't include the current project.
[...]
> The stylesheet is important and should be fixed. I don't care about the
> logo and favicon (warning: I've never been a fan of logos/icons,
> needless noise IMHO), but if you're willing to help maintain it then
> it's fine by me.
Thanks, Eric; that makes sense. How about this?
The purpose of this series is the first patch, which allows
old-fashioned instaweb to run even if /etc/gitweb.conf specifies some
layout it does not expect.
I suspect this problem is already fixed in maint by v1.7.2-rc0~55^2~3
(git-instaweb: Configure it to work with new gitweb structure,
2010-05-28; thanks, Pavan!), but users that do not like gitweb version
numbers with a 2 in them will not be able to use that.
Patches 2-4 fix some spurious 404 errors due to missing images,
noticed while debugging.
Patches are against Junio's maint-1.7.1.
Jonathan Nieder (4):
instaweb: ignore GITWEB_CONFIG_SYSTEM
gitweb: skip logo in atom feed when there is none
gitweb: make logo optional
instaweb: disable logo and favicon by default
git-instaweb.sh | 6 +++++-
gitweb/gitweb.perl | 12 +++++++-----
2 files changed, 12 insertions(+), 6 deletions(-)
--
1.7.2.2
next prev parent reply other threads:[~2010-09-02 23:54 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20100812131152.2333.9604.reportbug@octopus.hi.pengutronix.de>
2010-09-02 22:12 ` git instaweb for Debian squeeze (Re: Bug#592733: git instaweb broken) Jonathan Nieder
2010-09-02 22:36 ` Eric Wong
2010-09-02 23:52 ` Jonathan Nieder [this message]
2010-09-02 23:54 ` [PATCH 1/4] instaweb: ignore GITWEB_CONFIG_SYSTEM Jonathan Nieder
2010-09-03 17:23 ` Junio C Hamano
2010-09-03 18:20 ` Jonathan Nieder
2010-09-03 23:58 ` Jonathan Nieder
2010-09-04 1:36 ` Junio C Hamano
2010-09-04 2:19 ` Jonathan Nieder
2010-09-02 23:55 ` [PATCH 2/4] gitweb: skip logo in atom feed when there is none Jonathan Nieder
2010-09-02 23:56 ` [PATCH 3/4] gitweb: make logo optional Jonathan Nieder
2010-09-02 23:57 ` [PATCH 4/4] instaweb: disable logo and favicon by default Jonathan Nieder
2010-09-03 2:19 ` [PATCH v2 " Jonathan Nieder
2010-09-03 1:09 ` [PATCH/RFC maint-1.7.1 0/4] instaweb 1.7.1 fixes for Debian squeeze Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100902235237.GA6466@burratino \
--to=jrnieder@gmail.com \
--cc=git@vger.kernel.org \
--cc=jnareb@gmail.com \
--cc=normalperson@yhbt.net \
--cc=pavan.sss1991@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.