From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Egger Subject: Re: [PATCH 00/13] Nested Virtualization: Overview Date: Fri, 3 Sep 2010 13:23:48 +0200 Message-ID: <201009031323.49397.Christoph.Egger@amd.com> References: <201009011653.27082.Christoph.Egger@amd.com> <1A42CE6F5F474C41B63392A5F80372B22A7C1D0B@shsmsx501.ccr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1A42CE6F5F474C41B63392A5F80372B22A7C1D0B@shsmsx501.ccr.corp.intel.com> Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: "Dong, Eddie" Cc: "xen-devel@lists.xensource.com" , Tim Deegan List-Id: xen-devel@lists.xenproject.org On Friday 03 September 2010 10:12:08 Dong, Eddie wrote: > The fundamental argument of whether we should convert vendor specific code > into vendor neutral code is not solved yet. > I guess I don;t need to review rest of the code due to this :) I strongly > suggest we remove those unnecessary wrapper for readibilty, flexibility and > performance. I am sort of surprised that you raise the same things again that have been discussed in the last round. Please correct me if I am wrong: This sounds to me that the statements/explanations from Keir, Tim and me are not clear to you. Please feel free to ask whatever is unclear / questionable to you. > BTW, VMX has a policy to access VMCS field only when it is a must. SVM, too. AFAICS, the difference is the method *how* to access fields. Christoph > Thanks, Eddie > > Christoph Egger wrote: > > Hi! > > > > This patch series brings Nested Virtualization to Xen. > > This is the third patch series. Improvements to the > > previous patch submission: > > > > - Incorporated feedback discussion with Keir, Tim and Eddie. > > > > There might still be some nuances to fiddle with to make it > > fit for VMX. Feedback from Intel is appreciated, therefore. > > > > The patch series: > > > > patch 01: add nestedhvm guest config option to the tools. > > This is the only one patch touching the tools > > patch 02: Add data structures for nested virtualization. > > patch 03: add nestedhvm function hooks. > > patch 04: The heart of nested virtualization. > > patch 05: Allow switch to paged real mode during vmrun emulation. > > Emulate cr0 and cr4 when guest does not intercept > > them (i.e. Hyper-V/Windows7, KVM) > > patch 06: When injecting an exception into nested guest, inject > > #VMEXIT into the guest if intercepted. > > patch 07: Allow guest to enable SVM in EFER. > > patch 08: Handle interrupts (generic part). > > patch 09: SVM specific implementation for nested virtualization. > > patch 10: Handle interrupts (SVM specific). > > patch 11: The piece of code that effectively turns on nested > > virtualization. patch 12: Move dirty_vram from struct hvm_domain to > > struct p2m_domain. This change is the first part > > from a larger not-yet-ready change where the vram > > and log_dirty tracking is teached to work on per > > p2m. > > patch 13: Handle nested pagefault to enable hap-on-hap and handle > > nested guest page-table-walks to emulate > > instructions the guest does not intercept (i.e. > > WBINVD with Windows 7). -- ---to satisfy European Law for business letters: Advanced Micro Devices GmbH Einsteinring 24, 85609 Dornach b. Muenchen Geschaeftsfuehrer: Alberto Bozzo, Andrew Bowd Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen Registergericht Muenchen, HRB Nr. 43632