From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mike Frysinger <vapier@gentoo.org>
Date: Fri, 3 Sep 2010 17:03:55 -0400
Subject: [U-Boot] [PATCH] NET: add ENC28J60 driver using SPI framework
In-Reply-To: <4C815B33.8000107@emk-elektronik.de>
References: <1282740459-7941-1-git-send-email-u-boot@emk-elektronik.de>
	<201009031551.04080.vapier@gentoo.org>
	<4C815B33.8000107@emk-elektronik.de>
Message-ID: <201009031703.56678.vapier@gentoo.org>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Friday, September 03, 2010 16:31:47 Reinhard Meyer wrote:
> int enc_initialize(int bus, int cs, int speed)

should take the same parameters (including type) as spi_setup_slave

> 	eth_register(&(enc->netdev));

no need for the () before the &

> not sure, however, if calling spi_setup_slave() is ok at this point.

i believe the func should only doing validation on the arguments.  it shouldnt 
need to talk to any actual hardware.  maybe this needs codifying in the API 
documentation.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20100903/3bb55261/attachment.pgp