All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: "Prashant P. Shah" <pshah.mumbai@gmail.com>
Cc: gregkh@suse.de, wfp5p@virginia.edu, apatard@mandriva.com,
	randy.dunlap@oracle.com, devel@driverdev.osuosl.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: xgifb: fixed many style issues in XGI_accel.c
Date: Sat, 4 Sep 2010 21:49:02 -0700	[thread overview]
Message-ID: <20100905044902.GA3130@kroah.com> (raw)
In-Reply-To: <1283595045-6922-1-git-send-email-pshah.mumbai@gmail.com>

On Sat, Sep 04, 2010 at 03:40:45PM +0530, Prashant P. Shah wrote:
> This is a patch to the XGI_accel.c file that fixes many style
> issues found by the checkpatch.pl tool.
> - extra spaces
> - invalid code indent
> - extra braces
> - invalid comment style
> 
> Signed-off-by: Prashant P. Shah <pshah.mumbai@gmail.com>

Um, I think you forgot to build this patch, it dies a horrible death.

Please always test your patches before sending them out.

thanks,

greg k-h

  reply	other threads:[~2010-09-05  6:33 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-04 10:10 [PATCH] Staging: xgifb: fixed many style issues in XGI_accel.c Prashant P. Shah
2010-09-05  4:49 ` Greg KH [this message]
2010-09-05  8:47   ` Prashant Shah

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100905044902.GA3130@kroah.com \
    --to=greg@kroah.com \
    --cc=apatard@mandriva.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pshah.mumbai@gmail.com \
    --cc=randy.dunlap@oracle.com \
    --cc=wfp5p@virginia.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.