diff for duplicates of <20100905192335.GA8140@albatros> diff --git a/a/1.txt b/N1/1.txt index fe1281a..7b9f7df 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -20,7 +20,7 @@ No, the original code increments new_disk and then dereferences mirrors. The full code: for (rdev = rcu_dereference(conf->mirrors[new_disk].rdev); - r1_bio->bios[new_disk] = IO_BLOCKED || + r1_bio->bios[new_disk] == IO_BLOCKED || !rdev || !test_bit(In_sync, &rdev->flags) || test_bit(WriteMostly, &rdev->flags); rdev = rcu_dereference(conf->mirrors[++new_disk].rdev)) { @@ -29,7 +29,7 @@ The full code: r1_bio->bios[new_disk] != IO_BLOCKED) wonly_disk = new_disk; - if (new_disk = conf->raid_disks - 1) { + if (new_disk == conf->raid_disks - 1) { new_disk = wonly_disk; break; } @@ -41,7 +41,7 @@ The full code: ... } - = + == a; while (b) { @@ -50,7 +50,7 @@ The full code: c = f(++g); } - = + == a; while (b) { @@ -60,7 +60,7 @@ The full code: c = f(g); } - = + == for (a; b; c = f(g)) { ... @@ -71,3 +71,7 @@ Or you mean smth more? -- Vasiliy +-- +To unsubscribe from this list: send the line "unsubscribe linux-raid" in +the body of a message to majordomo@vger.kernel.org +More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/a/content_digest b/N1/content_digest index ad21d46..494dd62 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -2,7 +2,7 @@ "ref\020100905190139.GA3163@merkur.ravnborg.org\0" "From\0Kulikov Vasiliy <segooon@gmail.com>\0" "Subject\0Re: [PATCH] md: do not use ++ in rcu_dereference() argument\0" - "Date\0Sun, 05 Sep 2010 19:23:35 +0000\0" + "Date\0Sun, 5 Sep 2010 23:23:35 +0400\0" "To\0Sam Ravnborg <sam@ravnborg.org>\0" "Cc\0kernel-janitors@vger.kernel.org" Neil Brown <neilb@suse.de> @@ -33,7 +33,7 @@ "The full code:\n" "\n" "\t\tfor (rdev = rcu_dereference(conf->mirrors[new_disk].rdev);\n" - "\t\t r1_bio->bios[new_disk] = IO_BLOCKED ||\n" + "\t\t r1_bio->bios[new_disk] == IO_BLOCKED ||\n" "\t\t !rdev || !test_bit(In_sync, &rdev->flags)\n" "\t\t\t || test_bit(WriteMostly, &rdev->flags);\n" "\t\t rdev = rcu_dereference(conf->mirrors[++new_disk].rdev)) {\n" @@ -42,7 +42,7 @@ "\t\t\t\tr1_bio->bios[new_disk] != IO_BLOCKED)\n" "\t\t\t\twonly_disk = new_disk;\n" "\n" - "\t\t\tif (new_disk = conf->raid_disks - 1) {\n" + "\t\t\tif (new_disk == conf->raid_disks - 1) {\n" "\t\t\t\tnew_disk = wonly_disk;\n" "\t\t\t\tbreak;\n" "\t\t\t}\n" @@ -54,7 +54,7 @@ " ...\n" " } \n" "\n" - " =\n" + " ==\n" "\n" " a;\n" " while (b) {\n" @@ -63,7 +63,7 @@ " c = f(++g);\n" " }\n" "\n" - " =\n" + " ==\n" "\n" " a;\n" " while (b) {\n" @@ -73,7 +73,7 @@ " c = f(g);\n" " }\n" "\n" - " =\n" + " ==\n" "\n" " for (a; b; c = f(g)) {\n" " ...\n" @@ -83,6 +83,10 @@ "Or you mean smth more?\n" "\n" "-- \n" - Vasiliy + "Vasiliy\n" + "--\n" + "To unsubscribe from this list: send the line \"unsubscribe linux-raid\" in\n" + "the body of a message to majordomo@vger.kernel.org\n" + More majordomo info at http://vger.kernel.org/majordomo-info.html -8649d02fde497ebf5d0335dd999b9d7de1f34ee899aa8ee9717ff0b424099181 +debd2b733bc34890e05b686ff17e62766b11502b0225c8660c6d673b40ffc447
diff --git a/a/1.txt b/N2/1.txt index fe1281a..208e73c 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -20,7 +20,7 @@ No, the original code increments new_disk and then dereferences mirrors. The full code: for (rdev = rcu_dereference(conf->mirrors[new_disk].rdev); - r1_bio->bios[new_disk] = IO_BLOCKED || + r1_bio->bios[new_disk] == IO_BLOCKED || !rdev || !test_bit(In_sync, &rdev->flags) || test_bit(WriteMostly, &rdev->flags); rdev = rcu_dereference(conf->mirrors[++new_disk].rdev)) { @@ -29,7 +29,7 @@ The full code: r1_bio->bios[new_disk] != IO_BLOCKED) wonly_disk = new_disk; - if (new_disk = conf->raid_disks - 1) { + if (new_disk == conf->raid_disks - 1) { new_disk = wonly_disk; break; } @@ -41,7 +41,7 @@ The full code: ... } - = + == a; while (b) { @@ -50,7 +50,7 @@ The full code: c = f(++g); } - = + == a; while (b) { @@ -60,7 +60,7 @@ The full code: c = f(g); } - = + == for (a; b; c = f(g)) { ... diff --git a/a/content_digest b/N2/content_digest index ad21d46..51ab0ac 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -2,7 +2,7 @@ "ref\020100905190139.GA3163@merkur.ravnborg.org\0" "From\0Kulikov Vasiliy <segooon@gmail.com>\0" "Subject\0Re: [PATCH] md: do not use ++ in rcu_dereference() argument\0" - "Date\0Sun, 05 Sep 2010 19:23:35 +0000\0" + "Date\0Sun, 5 Sep 2010 23:23:35 +0400\0" "To\0Sam Ravnborg <sam@ravnborg.org>\0" "Cc\0kernel-janitors@vger.kernel.org" Neil Brown <neilb@suse.de> @@ -33,7 +33,7 @@ "The full code:\n" "\n" "\t\tfor (rdev = rcu_dereference(conf->mirrors[new_disk].rdev);\n" - "\t\t r1_bio->bios[new_disk] = IO_BLOCKED ||\n" + "\t\t r1_bio->bios[new_disk] == IO_BLOCKED ||\n" "\t\t !rdev || !test_bit(In_sync, &rdev->flags)\n" "\t\t\t || test_bit(WriteMostly, &rdev->flags);\n" "\t\t rdev = rcu_dereference(conf->mirrors[++new_disk].rdev)) {\n" @@ -42,7 +42,7 @@ "\t\t\t\tr1_bio->bios[new_disk] != IO_BLOCKED)\n" "\t\t\t\twonly_disk = new_disk;\n" "\n" - "\t\t\tif (new_disk = conf->raid_disks - 1) {\n" + "\t\t\tif (new_disk == conf->raid_disks - 1) {\n" "\t\t\t\tnew_disk = wonly_disk;\n" "\t\t\t\tbreak;\n" "\t\t\t}\n" @@ -54,7 +54,7 @@ " ...\n" " } \n" "\n" - " =\n" + " ==\n" "\n" " a;\n" " while (b) {\n" @@ -63,7 +63,7 @@ " c = f(++g);\n" " }\n" "\n" - " =\n" + " ==\n" "\n" " a;\n" " while (b) {\n" @@ -73,7 +73,7 @@ " c = f(g);\n" " }\n" "\n" - " =\n" + " ==\n" "\n" " for (a; b; c = f(g)) {\n" " ...\n" @@ -85,4 +85,4 @@ "-- \n" Vasiliy -8649d02fde497ebf5d0335dd999b9d7de1f34ee899aa8ee9717ff0b424099181 +277e67791e6196354b76520582427e93a1b7b4096de099c750bc021b33c6b636
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.