From: Stanislaw Gruszka <sgruszka@redhat.com>
To: "Berg, Johannes" <johannes.berg@intel.com>
Cc: "Guy, Wey-Yi W" <wey-yi.w.guy@intel.com>,
Johannes Berg <johannes@sipsolutions.net>,
"Chatre, Reinette" <reinette.chatre@intel.com>,
"John W. Linville" <linville@tuxdriver.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 02/13] iwlwifi: unify scan start checks
Date: Mon, 6 Sep 2010 09:30:33 +0200 [thread overview]
Message-ID: <20100906073030.GA3024@redhat.com> (raw)
In-Reply-To: <C5C86A19469DAE48AAAD0E5F3716E44501CDC1C78D@irsmsx504.ger.corp.intel.com>
On Fri, Sep 03, 2010 at 03:25:21PM +0100, Berg, Johannes wrote:
> > > set_bit(STATUS_SCAN_HW, &priv->status);
> > >
> > > - if (priv->cfg->ops->hcmd->set_pan_params &&
> > > - priv->cfg->ops->hcmd->set_pan_params(priv))
> > > - goto done;
> > > + if (priv->cfg->ops->hcmd->set_pan_params) {
> > > + ret = priv->cfg->ops->hcmd->set_pan_params(priv);
> > > + if (ret)
> > > + return ret;
> > > + }
>
> > STATUS_SCAN_HW bit still set here
>
> Good catch.
+1
>Stanislaw, would you mind fixing that? Seems easier than for me to re-send a part of your patch series, but I can do if you prefer.
I will fix.
Stanislaw
next prev parent reply other threads:[~2010-09-06 7:35 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-03 11:57 [PATCH 0/13] iwlwifi: rewrite iwl-scan.c to avoid race conditions Stanislaw Gruszka
2010-09-03 11:57 ` [PATCH 01/13] iwlwifi: remove unused conf variables Stanislaw Gruszka
2010-09-03 11:57 ` [PATCH 02/13] iwlwifi: unify scan start checks Stanislaw Gruszka
2010-09-03 14:23 ` Guy, Wey-Yi
2010-09-03 14:25 ` Berg, Johannes
2010-09-06 7:30 ` Stanislaw Gruszka [this message]
2010-09-03 11:57 ` [PATCH 03/13] iwlwifi: move scan completed flags handling Stanislaw Gruszka
2010-09-03 14:29 ` Guy, Wey-Yi
2010-09-03 14:31 ` Berg, Johannes
2010-09-03 11:57 ` [PATCH 04/13] iwlwifi: cancel scan when down the device Stanislaw Gruszka
2010-09-03 12:07 ` Johannes Berg
2010-09-03 14:38 ` Guy, Wey-Yi
2010-09-06 7:32 ` Stanislaw Gruszka
2010-09-03 11:57 ` [PATCH 05/13] iwlwifi: use IWL_DEBUG_SCAN Stanislaw Gruszka
2010-09-03 11:57 ` [PATCH 06/13] iwlwifi: report scan completion when abort fail Stanislaw Gruszka
2010-09-03 11:57 ` [PATCH 07/13] iwlwifi: do not queue abort_scan work if can sleep Stanislaw Gruszka
2010-09-03 11:57 ` [PATCH 08/13] iwlwifi: avoid dropping muttex in iwl_scan_cancel_timeout Stanislaw Gruszka
2010-09-03 14:53 ` Guy, Wey-Yi
2010-09-06 7:33 ` Stanislaw Gruszka
2010-09-03 11:57 ` [PATCH 09/13] iwlwifi: rewrite scan completion Stanislaw Gruszka
2010-09-03 11:57 ` [PATCH 10/13] iwlwifi: force scan complete after timeout Stanislaw Gruszka
2010-09-03 12:15 ` Johannes Berg
2010-09-03 11:57 ` [PATCH 11/13] iwlwifi: assure we complete scan in scan_abort and scan_check works Stanislaw Gruszka
2010-09-03 11:57 ` [PATCH 12/13] iwlwifi: do not force complete scan too early Stanislaw Gruszka
2010-09-03 11:57 ` [PATCH 13/13] mac80211: wait for scan work complete before restarting hw Stanislaw Gruszka
2010-09-03 12:21 ` [PATCH 0/13] iwlwifi: rewrite iwl-scan.c to avoid race conditions Johannes Berg
2010-09-03 12:55 ` Stanislaw Gruszka
2010-09-03 13:11 ` Johannes Berg
2010-09-03 15:04 ` Guy, Wey-Yi
2010-09-06 7:37 ` Stanislaw Gruszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100906073030.GA3024@redhat.com \
--to=sgruszka@redhat.com \
--cc=johannes.berg@intel.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=reinette.chatre@intel.com \
--cc=wey-yi.w.guy@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.