From: Anton Vorontsov <cbouatmailru@gmail.com>
To: Zang Roy-R61911 <r61911@freescale.com>
Cc: Wood Scott-B07421 <B07421@freescale.com>,
Lan Chunhe-B25806 <B25806@freescale.com>,
linuxppc-dev@ozlabs.org, linux-mtd@lists.infradead.org,
akpm@linux-foundation.org,
Gala Kumar-B11780 <B11780@freescale.com>
Subject: Re: [PATCH 1/3][MTD] P4080/eLBC: Make Freescale elbc interrupt common to elbc devices
Date: Mon, 6 Sep 2010 13:44:14 +0400 [thread overview]
Message-ID: <20100906094414.GA27034@oksana.dev.rtsoft.ru> (raw)
In-Reply-To: <3850A844E6A3854C827AC5C0BEC7B60A1B3872@zch01exm23.fsl.freescale.net>
On Mon, Sep 06, 2010 at 05:24:35PM +0800, Zang Roy-R61911 wrote:
[..]
> > mxmr = &fsl_lbc_ctrl_dev->regs->mcmr;
> That makes sense. A global or local variable for fsl_lbc_ctrl_dev->regs? Which one is better?
The less global variables, the better. So, I'd vote for
a local one.
> > [...]
> > > > > +static int __devinit fsl_lbc_ctrl_probe(struct of_device *ofdev,
> > > > > + const struct of_device_id *match)
> > > > > +{
> > > > > + int ret = 0;
> > > >
> > > > no need for the initial value here.
> > > Any harm?
> >
> > Probably not as gcc will likely optimize it away,
> > but it's not needed, so why keep it there?
> habit.
;-)
Thanks,
--
Anton Vorontsov
email: cbouatmailru@gmail.com
irc://irc.freenode.net/bd2
next prev parent reply other threads:[~2010-09-06 9:44 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-06 2:51 [PATCH 1/3][MTD] P4080/eLBC: Make Freescale elbc interrupt common to elbc devices Roy Zang
2010-08-06 2:51 ` [PATCH 2/3][MTD] P4080/nand: Only make elbc nand driver detect nand flash partitions Roy Zang
2010-08-06 2:51 ` [PATCH 3/3][MTD] P4080/nand: Fix the freescale lbc issue with 36bit mode Roy Zang
2010-09-03 11:36 ` Anton Vorontsov
2010-09-06 3:56 ` Zang Roy-R61911
2010-09-06 3:56 ` Zang Roy-R61911
2010-09-03 11:43 ` [PATCH 2/3][MTD] P4080/nand: Only make elbc nand driver detect nand flash partitions Anton Vorontsov
2010-09-03 17:33 ` Scott Wood
2010-09-03 17:33 ` Scott Wood
2010-09-06 3:40 ` Zang Roy-R61911
2010-09-06 3:40 ` Zang Roy-R61911
2010-09-06 4:49 ` Zang Roy-R61911
2010-09-06 4:49 ` Zang Roy-R61911
2010-09-06 8:09 ` Anton Vorontsov
2010-09-06 8:38 ` Zang Roy-R61911
2010-09-06 8:38 ` Zang Roy-R61911
2010-08-09 7:33 ` [PATCH 1/3][MTD] P4080/eLBC: Make Freescale elbc interrupt common to elbc devices Zang Roy-R61911
2010-08-09 7:33 ` Zang Roy-R61911
2010-08-29 11:06 ` Artem Bityutskiy
2010-08-11 2:45 ` Zang Roy-R61911
2010-08-11 2:45 ` Zang Roy-R61911
2010-09-03 10:33 ` Zang Roy-R61911
2010-09-03 10:33 ` Zang Roy-R61911
2010-09-03 11:27 ` Anton Vorontsov
2010-09-06 3:38 ` Zang Roy-R61911
2010-09-06 3:38 ` Zang Roy-R61911
2010-09-06 8:21 ` Anton Vorontsov
2010-09-06 9:24 ` Zang Roy-R61911
2010-09-06 9:24 ` Zang Roy-R61911
2010-09-06 9:44 ` Anton Vorontsov [this message]
2010-09-06 10:15 ` Zang Roy-R61911
2010-09-06 10:15 ` Zang Roy-R61911
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100906094414.GA27034@oksana.dev.rtsoft.ru \
--to=cbouatmailru@gmail.com \
--cc=B07421@freescale.com \
--cc=B11780@freescale.com \
--cc=B25806@freescale.com \
--cc=akpm@linux-foundation.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=r61911@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.