From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Axel Lin <axel.lin@gmail.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
Liam Girdwood <lrg@slimlogic.co.uk>
Subject: Re: [PATCH] regulator: wm831x-ldo - fix the logic to set REGULATOR_MODE_IDLE and REGULATOR_MODE_STANDBY modes
Date: Mon, 6 Sep 2010 10:44:38 +0100 [thread overview]
Message-ID: <20100906094437.GB10367@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <1283762893.10643.2.camel@mola>
On Mon, Sep 06, 2010 at 04:48:13PM +0800, Axel Lin wrote:
> Problem description in current implementation:
> When setting REGULATOR_MODE_IDLE mode, current implementation set
> WM831X_LDO1_LP_MODE bit of ctrl_reg (which is wrong, it should clear the bit).
Again, it would be really helpful if you could make your analysis
clearer - at no point do you explain why you think the chip settings
that result from your changes are correct. Your message explains that
the status readback differs from the settings but it doesn't explain how
you know which bit of code is correct. This means that your messages
set off alarm bells as it looks like you're just guessing about what
needs to be done to the chip.
In this case your patch appears to be OK so:
Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
prev parent reply other threads:[~2010-09-06 9:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-06 8:48 [PATCH] regulator: wm831x-ldo - fix the logic to set REGULATOR_MODE_IDLE and REGULATOR_MODE_STANDBY modes Axel Lin
2010-09-06 9:44 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100906094437.GB10367@rakim.wolfsonmicro.main \
--to=broonie@opensource.wolfsonmicro.com \
--cc=axel.lin@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.