From: Dave Chinner <david@fromorbit.com>
To: Arkadiusz Miskiewicz <arekm@maven.pl>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] Extend project quotas to support 32bit project identificators. [version 3]
Date: Mon, 6 Sep 2010 22:50:33 +1000 [thread overview]
Message-ID: <20100906125033.GB7362@dastard> (raw)
In-Reply-To: <201009061236.21010.arekm@maven.pl>
On Mon, Sep 06, 2010 at 12:36:20PM +0200, Arkadiusz Miskiewicz wrote:
> On Monday 06 of September 2010, Dave Chinner wrote:
> > On Sat, Aug 28, 2010 at 12:39:58AM +0200, Arkadiusz Miśkiewicz wrote:
>
> > > +static inline void xfs_sb_version_addprojid32bit(xfs_sb_t *sbp)
> > > +{
> > > + sbp->sb_versionnum |= XFS_SB_VERSION_MOREBITSBIT;
> > > + sbp->sb_features2 |= XFS_SB_VERSION2_PROJID32BIT;
> > > +}
> >
> > This also needs to set the bit in the sbp->sb_bad_features2 field.
>
> Hm, why all existing xfs_sb_version_addxyz() don't update it then?
The only one that updates sb_features2 - attr2 - is specially
handled in the mount path and sb_bad_features2 is updated there.
For correct handling in all cases, we should be updating both
both fields simultaneously...
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2010-09-06 12:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-25 21:09 [PATCH] Extend project quotas to support 32bit project identificators Arkadiusz Miśkiewicz
2010-08-26 6:49 ` [PATCH] Implictly set PROJID32BIT features2 bit when using 32bit project ids Arkadiusz Miśkiewicz
2010-08-27 22:39 ` [PATCH] Extend project quotas to support 32bit project identificators. [version 3] Arkadiusz Miśkiewicz
2010-08-28 8:44 ` [PATCH] xfsprogs: projid32bit handling Arkadiusz Miśkiewicz
2010-09-05 23:22 ` [PATCH] Extend project quotas to support 32bit project identificators. [version 3] Dave Chinner
2010-09-06 10:36 ` Arkadiusz Miskiewicz
2010-09-06 12:50 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100906125033.GB7362@dastard \
--to=david@fromorbit.com \
--cc=arekm@maven.pl \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.